Review main Merged

73043[TASK] Avoid StandaloneView() in functional tests

Stefan Bürk CR +2 V +2 Expert +901 −723 updated 01/19/22, 14:35

Commit message

StandaloneView() initalizes an ExtbaseRequest in
__construct() and adds it to the rendering context.

This is unfortunate for ViewHelper tests, since it
hides the information if a specific ViewHelper has
a dependency to a request.

This patch replaces all StandaloneView usages in
functional tests with the TemplateView class of
typo3fluid, which doesn't do anything with request.

When needed, request objects are created and added within
the test manually, making this dependency transparent.

The patch adds some minor refactorings of some tests
along the way and fixes a couple of smaller bugs.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 87

Show 67 more files

Review log 1118

  1. Stefan Bürk uploaded patch set 1 01/17/22, 12:28

  2. Stefan Bürk uploaded patch set 2 01/17/22, 12:29

  3. core-ci voted on patch set 1 V +1 01/17/22, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22182

  4. core-ci voted on patch set 2 V +1 01/17/22, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22183

  5. Christian Kuhn uploaded patch set 3 01/17/22, 19:45

  6. core-ci voted on patch set 3 V +1 01/17/22, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22196

  7. Stefan Bürk uploaded patch set 4 01/18/22, 22:49

  8. Stefan Bürk updated the commit message in patch set 5 01/18/22, 22:52

  9. core-ci voted on patch set 4 V +1 01/18/22, 23:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22236

  10. core-ci voted on patch set 5 V +1 01/18/22, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22237

  11. Christian Kuhn commented on patch set 5 CR -1 01/19/22, 13:25

    on it.
  12. Christian Kuhn uploaded patch set 6 01/19/22, 13:55

  13. Christian Kuhn uploaded patch set 7 01/19/22, 13:55

  14. core-ci voted on patch set 6 V -1 01/19/22, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22267

  15. core-ci voted on patch set 7 V +1 01/19/22, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22268

  16. Christian Kuhn voted on patch set 7 V +1 CR +1 01/19/22, 14:22

  17. Benni Mack voted on patch set 7 V +2 CR +2 01/19/22, 14:35

  18. Benni Mack merged patch set 8 01/19/22, 14:35