Review main Merged

73044[BUGFIX] Add PHP 8.0/8.1 compatibility for Import

TYPO3com CR +2 V +2 Easy +1 −1 updated 01/19/22, 09:33

Commit message

Importer fails to process soft references (e.g. phone numbers, email,
links etc.) in PHP 8.0/8.1 with "Undefined array key 1" as the string
cannot split into two variables. Simple workaround is to define a colon as
default value.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 610

  1. TYPO3com uploaded patch set 1 01/17/22, 18:10

  2. core-ci voted on patch set 1 V -1 01/17/22, 18:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22189

  3. Reiner Kempkes commented on patch set 1 01/17/22, 18:33

    I traced it a bit deeper now: it seems to fail only for phone number soft references, everything else works after the import. Propably there might be another bug, as i am unable to edit the phone number using the RTE link popup (HTTP 502).
  4. core-ci voted on patch set 1 V +1 01/17/22, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22189

  5. Benni Mack updated the commit message in patch set 2 01/18/22, 12:41

  6. Benni Mack commented on patch set 2 CR +1 01/18/22, 12:42

    Reply

    I think this is another issue https://forge.typo3.org/issues/91734 so let's get your issue in first.
  7. core-ci voted on patch set 2 V +1 01/18/22, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22224

  8. Benni Mack voted on patch set 2 V +1 01/19/22, 07:08

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 01/19/22, 09:32

  10. Christian Kuhn merged patch set 3 01/19/22, 09:33