Review main Merged

73047[BUGFIX] Properly sort backend layout rows and cols

Georg Ringer CR +2 V +2 Easy +9 −5 updated 01/24/22, 22:53

Commit message

This fixes the sorting of backend layout rows
and cols in the page module, depending on TSconfig.

1. The rows are now sorted by their key again
2. Using SHARED.colPos_list does no longer override
   the order, defined in the backend layout.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1622

  1. Georg Ringer uploaded patch set 1 01/17/22, 20:56

  2. core-ci voted on patch set 1 V -1 01/17/22, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22198

  3. Georg Ringer commented on patch set 2 01/17/22, 21:15

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 01/17/22, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22200

  5. Georg Ringer commented on patch set 2 01/17/22, 21:45

    This change is ready for review.
  6. Christian Kuhn commented on patch set 2 01/18/22, 10:09

    a similar patch for the same issue, codewise at a different place has been pushed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/73054
  7. Felix Heller rebased onto patch set 3 01/18/22, 10:19

  8. Felix Heller uploaded patch set 4 01/18/22, 10:34

  9. core-ci voted on patch set 3 V +1 01/18/22, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22216

  10. core-ci voted on patch set 4 V +1 01/18/22, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22219

  11. Felix Heller commented on patch set 4 01/18/22, 13:35

    Reply

    I've committed the changes as patch set 4 in this issue. Sorry for messing around with the Git repository. I've abandoned my two other commits (https://review.typo3.org/c/Packages/TYPO3.CMS/+/73054 and https://review.typo3.org/c/Packages/TYPO3.CMS/+/73056).
  12. Oli Bartsch uploaded patch set 5 01/24/22, 11:50

  13. Oli Bartsch voted on patch set 5 V +1 CR +1 01/24/22, 11:50

  14. Oli Bartsch voted on patch set 5 V 0 CR 0 01/24/22, 11:51

  15. Oli Bartsch updated the commit message in patch set 6 01/24/22, 11:51

  16. core-ci voted on patch set 5 V +1 01/24/22, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22455

  17. core-ci voted on patch set 6 V +1 01/24/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22456

  18. Oli Bartsch voted on patch set 6 V +1 CR +1 01/24/22, 12:09

  19. Jochen Roth voted on patch set 6 V +1 CR +1 01/24/22, 14:39

  20. Georg Ringer voted on patch set 6 V +1 CR +1 01/24/22, 22:52

  21. Oli Bartsch voted on patch set 6 V +2 CR +2 01/24/22, 22:53

  22. Oli Bartsch merged patch set 7 01/24/22, 22:53