73051[TASK] Refactor ext:scheduler controller and view
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 37
- Build/Sources/TypeScript/scheduler/Resources/Public/TypeScript/Scheduler.ts+10 −8
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+12 −12
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+861 −1183
- typo3/sysext/scheduler/Classes/Exception/InvalidDateException.phpnew+27 −0
- typo3/sysext/scheduler/Classes/SystemInformation/ToolbarItemProvider.php+3 −16
- typo3/sysext/scheduler/Classes/Task/Enumeration/Action.php+2 −8
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+7 −13
- typo3/sysext/scheduler/Classes/Exception.phpnew+27 −0
- typo3/sysext/scheduler/Classes/Scheduler.php+34 −38
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf+36 −15
- typo3/sysext/scheduler/Resources/Private/Partials/Backend/SchedulerModule/ServerTime.htmldeleted+0 −6
- typo3/sysext/scheduler/Resources/Private/Partials/Backend/SchedulerModule/TaskList.htmldeleted+0 −206
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditAdditionalFields.htmlnew+28 −0
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditDescriptionField.htmlnew+8 −0
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditDisableField.htmlnew+9 −0
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditFrequencyField.htmlnew+24 −0
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditMultipleField.htmlnew+9 −0
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditStartEndFields.htmlnew+47 −0
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditTaskGroupField.htmlnew+26 −0
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditTypeField.htmlnew+15 −0
Show 17 more files
- typo3/sysext/scheduler/Resources/Private/Partials/MultiRecordSelectionActions.htmlrenamed+4 −4
- typo3/sysext/scheduler/Resources/Private/Partials/ServerTime.htmlnew+15 −0
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.htmlnew+408 −0
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/CheckScreen.htmldeleted+0 −21
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/EditTask.htmldeleted+0 −162
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/Index.htmldeleted+0 −11
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/InfoScreen.htmldeleted+0 −45
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/InfoScreenNoClasses.htmldeleted+0 −1
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/ListTasks.htmldeleted+0 −3
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/ListTasksNoTasks.htmldeleted+0 −1
- typo3/sysext/scheduler/Resources/Private/Templates/AddTaskForm.htmlnew+51 −0
- typo3/sysext/scheduler/Resources/Private/Templates/CheckScreen.htmlnew+30 −0
- typo3/sysext/scheduler/Resources/Private/Templates/EditTaskForm.htmlnew+30 −0
- typo3/sysext/scheduler/Resources/Private/Templates/InfoScreen.htmlnew+58 −0
- typo3/sysext/scheduler/Resources/Private/Templates/ListTasks.htmlnew+24 −0
- typo3/sysext/scheduler/Resources/Public/JavaScript/Scheduler.js+1 −1
- typo3/sysext/scheduler/ext_tables.php+1 −1
Review log 1322
-
Christian Kuhn uploaded patch set 1 01/17/22, 22:18
-
core-ci voted on patch set 1 V -1 01/17/22, 22:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22206
-
Christian Kuhn uploaded patch set 2 01/18/22, 11:52
-
core-ci voted on patch set 2 V +1 01/18/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22220
-
Christian Kuhn uploaded patch set 3 01/18/22, 14:30
-
Christian Kuhn rebased onto patch set 4 01/18/22, 14:31
-
Christian Kuhn uploaded patch set 5 01/18/22, 14:33
-
core-ci voted on patch set 4 V -1 01/18/22, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22226
-
core-ci voted on patch set 3 V -1 01/18/22, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22225
-
core-ci voted on patch set 5 V -1 01/18/22, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22227
-
core-ci commented on patch set 5 01/18/22, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22227
-
Christian Kuhn uploaded patch set 6 01/18/22, 14:58
-
core-ci voted on patch set 6 V +1 01/18/22, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22228
-
Christian Kuhn uploaded patch set 7 01/18/22, 23:49
-
core-ci voted on patch set 7 V +1 01/19/22, 00:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22240
-
Christian Kuhn updated the commit message in patch set 8 01/19/22, 00:15
-
core-ci voted on patch set 8 V +1 01/19/22, 00:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22242
-
Stefan Bürk commented on patch set 8 CR -1 01/19/22, 13:42
on it - datetime get saved wrong (hour shift) -
Stefan Bürk commented on patch set 8 V +1 CR +1 01/19/22, 14:26
Massive work.Reply
Forget it. Cannot reproduce it anymore - seems to work now. Maybe soem opcache issues or something like that. -
Benni Mack voted on patch set 8 V +1 CR +1 01/19/22, 14:33
-
Christian Kuhn voted on patch set 8 V +2 CR +2 01/19/22, 14:38
-
Christian Kuhn merged patch set 9 01/19/22, 14:38