Review main Merged

73051[TASK] Refactor ext:scheduler controller and view

Christian Kuhn CR +2 V +2 Nightmare +1807 −1755 updated 01/19/22, 14:38

Commit message

This is a careful rewrite of the scheduler backend
module controller and its view. It reaches a
significantly better separation of concerns between
controller and view.

* The main dispatcher is much more clean and easier to
follow, the methods are smaller and better encapsulated.
* The controller has close to no state except services.
* Improved error handling and notification of edge cases.
* Improved GET/POST separation.
* Better named action and view GET/POST params.
* Improved shortcut namings.
* Minor usability improvements.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 37

Show 17 more files

Review log 1322

  1. Christian Kuhn uploaded patch set 1 01/17/22, 22:18

  2. core-ci voted on patch set 1 V -1 01/17/22, 22:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22206

  3. Christian Kuhn uploaded patch set 2 01/18/22, 11:52

  4. core-ci voted on patch set 2 V +1 01/18/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22220

  5. Christian Kuhn uploaded patch set 3 01/18/22, 14:30

  6. Christian Kuhn rebased onto patch set 4 01/18/22, 14:31

  7. Christian Kuhn uploaded patch set 5 01/18/22, 14:33

  8. core-ci voted on patch set 4 V -1 01/18/22, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22226

  9. core-ci voted on patch set 3 V -1 01/18/22, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22225

  10. core-ci voted on patch set 5 V -1 01/18/22, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22227

  11. core-ci commented on patch set 5 01/18/22, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22227

  12. Christian Kuhn uploaded patch set 6 01/18/22, 14:58

  13. core-ci voted on patch set 6 V +1 01/18/22, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22228

  14. Christian Kuhn uploaded patch set 7 01/18/22, 23:49

  15. core-ci voted on patch set 7 V +1 01/19/22, 00:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22240

  16. Christian Kuhn updated the commit message in patch set 8 01/19/22, 00:15

  17. core-ci voted on patch set 8 V +1 01/19/22, 00:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22242

  18. Stefan Bürk commented on patch set 8 CR -1 01/19/22, 13:42

    on it - datetime get saved wrong (hour shift)
  19. Stefan Bürk commented on patch set 8 V +1 CR +1 01/19/22, 14:26

    Massive work.

    Reply

    Forget it. Cannot reproduce it anymore - seems to work now. Maybe soem opcache issues or something like that.
  20. Benni Mack voted on patch set 8 V +1 CR +1 01/19/22, 14:33

  21. Christian Kuhn voted on patch set 8 V +2 CR +2 01/19/22, 14:38

  22. Christian Kuhn merged patch set 9 01/19/22, 14:38