73058[!!!][FEATURE] New Module Registration API
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 121
- Build/phpstan/phpstan-baseline.neon+0 −30
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+10 −24
- typo3/sysext/backend/Classes/Backend/ToolbarItems/HelpToolbarItem.php+17 −12
- typo3/sysext/backend/Classes/Backend/ToolbarItems/LiveSearchToolbarItem.php2+10 −9
- typo3/sysext/backend/Classes/Backend/ToolbarItems/UserToolbarItem.php+4 −7
- typo3/sysext/backend/Classes/Controller/AboutController.php3+10 −50
- typo3/sysext/backend/Classes/Controller/BackendController.php2+22 −42
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php2+10 −24
- typo3/sysext/backend/Classes/Controller/ShortcutController.php+2 −19
- typo3/sysext/backend/Classes/Domain/Model/Module/BackendModule.phpdeleted+0 −278
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.phpdeleted+0 −374
- typo3/sysext/backend/Classes/Domain/Repository/TableManualRepository.php+13 −12
- typo3/sysext/backend/Classes/Http/RouteDispatcher.php+17 −26
- typo3/sysext/backend/Classes/Middleware/BackendRouteInitialization.php+17 −18
- typo3/sysext/backend/Classes/Module/BaseModule.phpnew+238 −0
- typo3/sysext/backend/Classes/Module/BeforeModuleCreationEvent.phpnew+58 −0
- typo3/sysext/backend/Classes/Module/ExtbaseModule.phpnew+89 −0
- typo3/sysext/backend/Classes/Module/MenuModule.phpnew+179 −0
- typo3/sysext/backend/Classes/Module/Module.phpnew+54 −0
- typo3/sysext/backend/Classes/Module/ModuleFactory.phpnew+71 −0
Show 101 more files
- typo3/sysext/backend/Classes/Module/ModuleInterface.phpnew+151 −0
- typo3/sysext/backend/Classes/Module/ModuleLoader.phpdeleted+0 −411
- typo3/sysext/backend/Classes/Module/ModuleProvider.php2new+261 −0
- typo3/sysext/backend/Classes/Module/ModuleRegistry.php4new+152 −0
- typo3/sysext/backend/Classes/Module/ModuleStorage.phpdeleted+0 −68
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+2 −5
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+8 −11
- typo3/sysext/backend/Classes/ServiceProvider.php3+64 −0
- typo3/sysext/backend/Configuration/Backend/Modules.phpnew+64 −0
- typo3/sysext/backend/Configuration/Services.yaml+3 −3
- typo3/sysext/backend/Resources/Private/Partials/About/Modules.html+12 −10
- typo3/sysext/backend/Resources/Private/Partials/Backend/ModuleMenu.html+12 −12
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/HelpToolbarItemDropDown.html+7 −7
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItemDropDown.html+7 −7
- typo3/sysext/backend/Tests/Functional/Backend/Shortcut/ShortcutRepositoryTest.php+4 −5
- typo3/sysext/backend/Tests/Functional/Controller/ShortcutControllerTest.php+0 −2
- typo3/sysext/backend/Tests/Unit/Http/RouteDispatcherTest.php+18 −8
- typo3/sysext/backend/Tests/Unit/Module/ModuleLoaderTest.phpdeleted+0 −197
- typo3/sysext/backend/ext_tables.php+0 −64
- typo3/sysext/belog/Classes/Module/BackendLogModuleBootstrap.php+13 −11
- typo3/sysext/belog/Configuration/Backend/Modules.phpnew+21 −0
- typo3/sysext/belog/Configuration/Services.yaml+3 −0
- typo3/sysext/belog/ext_tables.php+0 −18
- typo3/sysext/beuser/Classes/Service/UserInformationService.php+9 −12
- typo3/sysext/beuser/Configuration/Backend/Modules.phpnew+50 −0
- typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html+3 −3
- typo3/sysext/beuser/ext_tables.phpdeleted+0 −41
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+12 −5
- typo3/sysext/core/Classes/Core/Bootstrap.php+0 −1
- typo3/sysext/core/Classes/Hooks/TcaItemsProcessorFunctions.php+19 −56
- typo3/sysext/core/Classes/Imaging/IconRegistry.php+0 −41
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+21 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php2+11 −150
- typo3/sysext/core/Configuration/Backend/Modules.phpnew+44 −0
- typo3/sysext/core/Configuration/TCA/be_groups.php+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96733-RemovedSupportForModuleHandlingBasedOnTBE_MODULES.rstnew+103 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-96733-DeprecatedTBE_MODULESRelatedFunctionality.rstnew+42 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96733-NewBackendModuleRegistrationAPI.rstnew+402 −0
- typo3/sysext/core/Tests/Acceptance/Application/ConfigurationModule/ConfigurationModuleProviderCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FileList/AbstractFileCest.php+1 −1
- typo3/sysext/core/Tests/Unit/Hooks/TcaItemsProcessorFunctionsTest.php+36 −66
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+0 −93
- typo3/sysext/core/ext_tables.php+0 −94
- typo3/sysext/dashboard/Configuration/Backend/Modules.phpnew+22 −0
- typo3/sysext/dashboard/Configuration/Backend/Routes.phpdeleted+0 −8
- typo3/sysext/dashboard/ext_tables.php+0 −20
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+2 −14
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+2 −3
- typo3/sysext/extbase/Classes/EventListener/AddDefaultModuleIcon.phpnew+39 −0
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+13 −3
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+9 −52
- typo3/sysext/extbase/Configuration/Services.yaml+5 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Web/RequestBuilderTest.php+133 −129
- typo3/sysext/extbase/Tests/Unit/Configuration/BackendConfigurationManagerTest.php+0 −28
- typo3/sysext/extensionmanager/Configuration/Backend/Modules.phpnew+45 −0
- typo3/sysext/extensionmanager/ext_tables.phpdeleted+0 −35
- typo3/sysext/filelist/Configuration/Backend/Modules.phpnew+21 −0
- typo3/sysext/filelist/ext_tables.phpdeleted+0 −23
- typo3/sysext/form/Configuration/Backend/Modules.phpnew+26 −0
- typo3/sysext/form/ext_tables.phpdeleted+0 −28
- typo3/sysext/indexed_search/Configuration/Backend/Modules.phpnew+21 −0
- typo3/sysext/indexed_search/ext_tables.php+0 −17
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+18 −25
- typo3/sysext/info/Configuration/Backend/Modules.phpnew+21 −0
- typo3/sysext/info/ext_tables.php+0 −14
- typo3/sysext/install/Classes/Updates/ShortcutRecordsMigration.php+6 −10
- typo3/sysext/install/Classes/ServiceProvider.php+1 −0
- typo3/sysext/install/Configuration/Backend/Modules.phpnew+57 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayGlobalMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+20 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+35 −0
- typo3/sysext/install/ext_tables.phpdeleted+0 −61
- typo3/sysext/linkvalidator/Configuration/Backend/Modules.phpnew+25 −0
- typo3/sysext/linkvalidator/ext_tables.php+0 −19
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/BackendModuleProvider.phpnew+49 −0
- typo3/sysext/lowlevel/Configuration/Backend/Modules.phpnew+36 −0
- typo3/sysext/lowlevel/Configuration/Services.yaml+13 −14
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf+2 −2
- typo3/sysext/lowlevel/ext_tables.phpdeleted+0 −38
- typo3/sysext/recordlist/Configuration/Backend/Modules.phpnew+22 −0
- typo3/sysext/recordlist/ext_tables.phpdeleted+0 −22
- typo3/sysext/recycler/Configuration/Backend/Modules.phpnew+22 −0
- typo3/sysext/recycler/ext_tables.phpdeleted+0 −24
- typo3/sysext/redirects/Configuration/Backend/Modules.phpnew+21 −0
- typo3/sysext/redirects/ext_tables.phpdeleted+0 −22
- typo3/sysext/reports/Configuration/Backend/Modules.phpnew+21 −0
- typo3/sysext/reports/ext_tables.phpdeleted+0 −22
- typo3/sysext/scheduler/Configuration/Backend/Modules.phpnew+21 −0
- typo3/sysext/scheduler/ext_tables.php+0 −16
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+21 −41
- typo3/sysext/setup/Configuration/Backend/Modules.phpnew+21 −0
- typo3/sysext/setup/ext_tables.php+0 −13
- typo3/sysext/tstemplate/Configuration/Backend/Modules.phpnew+21 −0
- typo3/sysext/tstemplate/ext_tables.php+0 −15
- typo3/sysext/viewpage/Configuration/Backend/Modules.phpnew+22 −0
- typo3/sysext/viewpage/ext_tables.phpdeleted+0 −22
- typo3/sysext/workspaces/Classes/Controller/AjaxController.php+5 −2
- typo3/sysext/workspaces/Configuration/Backend/Modules.phpnew+22 −0
- typo3/sysext/workspaces/ext_tables.php+0 −16
- composer.lock+6 −6
Review log 74132
Show 58107 earlier messages
-
Oli Bartsch uploaded patch set 1 01/18/22, 23:56
-
core-ci voted on patch set 1 V -1 01/19/22, 00:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22241
-
Benni Mack commented on patch set 1 01/19/22, 07:44
-
Benni Mack uploaded patch set 2 01/27/22, 22:04
-
core-ci voted on patch set 2 V -1 01/27/22, 22:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22600
-
Benni Mack uploaded patch set 3 01/27/22, 22:40
-
core-ci voted on patch set 3 V -1 01/27/22, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22603
-
Oli Bartsch uploaded patch set 4 01/28/22, 12:32
-
core-ci voted on patch set 4 V -1 01/28/22, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22620
-
Oli Bartsch uploaded patch set 5 01/28/22, 15:47
-
core-ci voted on patch set 5 V -1 01/28/22, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22628
-
Oli Bartsch uploaded patch set 6 01/28/22, 17:07
-
core-ci voted on patch set 6 V -1 01/28/22, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22630
-
Oli Bartsch uploaded patch set 7 01/28/22, 17:29
-
core-ci voted on patch set 7 V -1 01/28/22, 17:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22631
-
Oli Bartsch uploaded patch set 8 01/28/22, 22:16
-
core-ci voted on patch set 8 V -1 01/28/22, 22:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22640
-
Oli Bartsch uploaded patch set 9 01/28/22, 23:08
-
core-ci voted on patch set 9 V -1 01/28/22, 23:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22642
-
Benni Mack uploaded patch set 10 01/31/22, 13:53
-
core-ci voted on patch set 10 V -1 01/31/22, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22805
-
Benni Mack marked it ready for review 01/31/22, 16:30
-
Benni Mack uploaded patch set 11 02/01/22, 08:57
-
core-ci voted on patch set 11 V -1 02/01/22, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22864
-
Benni Mack uploaded patch set 12 02/01/22, 10:03
-
core-ci voted on patch set 12 V -1 02/01/22, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22867
-
Benni Mack uploaded patch set 13 02/01/22, 11:13
-
core-ci voted on patch set 13 V -1 02/01/22, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22868
-
Benni Mack uploaded patch set 14 02/01/22, 12:25
-
Benni Mack uploaded patch set 15 02/01/22, 12:41
-
core-ci voted on patch set 14 V -1 02/01/22, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22869
-
core-ci voted on patch set 15 V -1 02/01/22, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22872
-
Oli Bartsch uploaded patch set 16 02/01/22, 16:47
-
core-ci voted on patch set 16 V -1 02/01/22, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22884
-
Oli Bartsch uploaded patch set 17 02/01/22, 17:17
-
core-ci voted on patch set 17 V -1 02/01/22, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22885
-
Oli Bartsch uploaded patch set 18 02/01/22, 17:45
-
core-ci voted on patch set 18 V -1 02/01/22, 18:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22888
-
Oli Bartsch uploaded patch set 19 02/01/22, 20:53
-
core-ci voted on patch set 19 V -1 02/01/22, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22894
-
Benni Mack uploaded patch set 20 02/02/22, 08:12
-
core-ci voted on patch set 20 V -1 02/02/22, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22898
-
Benni Mack uploaded patch set 21 02/02/22, 10:22
-
core-ci voted on patch set 21 V -1 02/02/22, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22899
-
Benni Mack uploaded patch set 22 02/02/22, 11:59
-
Benni Mack commented on patch set 22 02/02/22, 11:59
ModuleProvider.php:220ReplyDone -
core-ci voted on patch set 22 V -1 02/02/22, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22902
-
Benni Mack uploaded patch set 23 02/02/22, 12:27
-
core-ci voted on patch set 23 V -1 02/02/22, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22904
-
Benni Mack uploaded patch set 24 02/02/22, 13:59
-
core-ci voted on patch set 24 V -1 02/02/22, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22906
-
Benni Mack updated the commit message in patch set 25 02/02/22, 16:09
-
core-ci voted on patch set 25 V -1 02/02/22, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22909
-
Benni Mack uploaded patch set 26 02/02/22, 16:25
-
core-ci voted on patch set 26 V -1 02/02/22, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22910
-
Benni Mack uploaded patch set 27 02/02/22, 16:53
-
core-ci voted on patch set 27 V -1 02/02/22, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22911
-
Benni Mack uploaded patch set 28 02/02/22, 17:26
-
core-ci voted on patch set 28 V -1 02/02/22, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22912
-
Oli Bartsch uploaded patch set 29 02/02/22, 19:15
-
Oli Bartsch uploaded patch set 30 02/02/22, 19:21
-
core-ci voted on patch set 29 V -1 02/02/22, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22918
-
core-ci voted on patch set 30 V -1 02/02/22, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22919
-
Benni Mack uploaded patch set 31 02/02/22, 19:42
-
core-ci voted on patch set 31 V -1 02/02/22, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22920
-
Benni Mack uploaded patch set 32 02/02/22, 20:01
-
Benni Mack uploaded patch set 33 02/02/22, 20:15
-
core-ci voted on patch set 32 V -1 02/02/22, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22921
-
core-ci voted on patch set 33 V -1 02/02/22, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22922
-
Oli Bartsch uploaded patch set 34 02/02/22, 21:16
-
core-ci voted on patch set 34 V -1 02/02/22, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22925
-
Oli Bartsch uploaded patch set 35 02/02/22, 23:16
-
core-ci voted on patch set 35 V -1 02/02/22, 23:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22928
-
Oli Bartsch uploaded patch set 36 02/03/22, 00:00
-
core-ci voted on patch set 36 V -1 02/03/22, 00:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22929
-
Oli Bartsch uploaded patch set 37 02/03/22, 01:17
-
core-ci voted on patch set 37 V +1 02/03/22, 01:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22931
-
Benjamin Franzke commented on patch set 37 02/03/22, 07:43
ExtensionManagementUtility.php:822I would suggest to store a reference to the router in $moduleRegistry->registerRoutesForModules (when called from the service provider) Then, whenever moduleRegistry->addModule() is invoked, the routes can be added to the router (as then a router reference is available) even after the initial route initialization. That means Router and ModuleRegistry state will *always* match, and it doens't matter whether Router or ModuleRegistry are initialized first. Then this registerRouteForModule call in here would be removed. -
Christian Kuhn commented on patch set 37 02/03/22, 10:15
LiveSearchToolbarItem.php:31when you're changing these to property promotion anyways, please go with readonly, or is there any reason to write that property again?AboutController.php:40controllers really should go readonly here.AboutController.php:96great seeing this gone.BackendController.php:165we still need this explicit exclution of 'user' / 'help' here? is there a better solution on the way, maybe with another patch?PageLayoutController.php:160really. please go readonly if you change that anyways. either do that, or don't switch to property promotion with this patch.ModuleRegistry.php:27do we need singleton here? couldn't that be done with a shared service, or is this just a fallback / to-be-sure thing? -
Benjamin Franzke commented on patch set 37 02/03/22, 10:22
ModuleRegistry.php:27ReplyNot shared but public, but yea following is actually interchangable: Singleton === public But SingletonInterface often helps with unit test that otherwise require alot of refactoring because `addSingletonInstance` is easier than `addInstance` when an unknown amount of instances is consumed. So: we never defined what to use for new code. I don't have a strong opinion here, but think public: true would be sufficient for new services, but SingletonInterface is "ok" in case it makes the patch cleaner in order to avoid 100 tests to be rewritten. In this special case though – as ModuleRegistry is referenced in a ServiceProvider, it would actually be the cleanest to define a factory in a ServiceProvider as well. (I see all ServiceProviders as minimal subset that can operate on it's own, without full-blown symfony DI, so I like to keep all ServiceProvider dependencies defined in ServiceProviders) -
Benjamin Franzke commented on patch set 37 02/03/22, 10:23
ModuleRegistry.php:27ReplyI meant "not shared" in a way like: It's shared anyway (and of course it should be shared), but "public" defaults to false and that's what needs to be defined. -
Oli Bartsch uploaded patch set 38 02/03/22, 14:29
-
core-ci voted on patch set 38 V +1 02/03/22, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22953
-
Oli Bartsch uploaded patch set 39 02/03/22, 16:22
-
Oli Bartsch commented on patch set 39 02/03/22, 16:23
LiveSearchToolbarItem.php:31ReplyDoneAboutController.php:40ReplyDoneBackendController.php:165ReplyDonePageLayoutController.php:160ReplyDone -
core-ci voted on patch set 39 V +1 02/03/22, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22956
-
Oli Bartsch uploaded patch set 40 02/03/22, 16:45
-
core-ci voted on patch set 40 V +1 02/03/22, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22959
-
Oli Bartsch uploaded patch set 41 02/03/22, 18:18
-
core-ci voted on patch set 41 V -1 02/03/22, 18:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22967
-
Oli Bartsch uploaded patch set 42 02/03/22, 18:49
-
core-ci voted on patch set 42 V -1 02/03/22, 19:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22969
-
Oli Bartsch uploaded patch set 43 02/04/22, 01:24
-
core-ci voted on patch set 43 V -1 02/04/22, 01:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22986
-
Oli Bartsch uploaded patch set 44 02/04/22, 11:46
-
core-ci voted on patch set 44 V -1 02/04/22, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22994
-
Oli Bartsch uploaded patch set 45 02/04/22, 16:53
-
core-ci voted on patch set 45 V -1 02/04/22, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23008
-
Oli Bartsch uploaded patch set 46 02/04/22, 17:01
-
core-ci voted on patch set 46 V -1 02/04/22, 17:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23009
-
Oli Bartsch uploaded patch set 47 02/04/22, 17:12
-
Oli Bartsch commented on patch set 46 02/04/22, 17:12
ExtensionManagementUtility.php:822ReplyDone -
core-ci voted on patch set 47 V -1 02/04/22, 17:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23011
-
Oli Bartsch uploaded patch set 48 02/04/22, 17:31
-
core-ci voted on patch set 48 V +1 02/04/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23014
-
Oli Bartsch uploaded patch set 49 02/04/22, 17:50
-
core-ci voted on patch set 49 V +1 02/04/22, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23015
-
Oli Bartsch uploaded patch set 50 02/04/22, 18:11
-
core-ci voted on patch set 50 V -1 02/04/22, 18:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23016
-
Oli Bartsch uploaded patch set 51 02/04/22, 21:05
-
core-ci voted on patch set 51 V +1 02/04/22, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23022
-
Oli Bartsch uploaded patch set 52 02/04/22, 21:20
-
core-ci voted on patch set 52 V +1 02/04/22, 21:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23023
-
Benjamin Franzke uploaded patch set 53 02/04/22, 21:58
-
Benjamin Franzke commented on patch set 53 02/04/22, 21:58
ModuleRegistry.php:27ReplyDoneServiceProvider.php:104This injection means that ModuleProvider needs to be defined as factory here. Otherwise requesting /typo3/, when the system is not yet installed will lead to: (1/1) #1519978105 TYPO3\CMS\Core\DependencyInjection\NotFoundException Container entry "TYPO3\CMS\Backend\Module\ModuleProvider" is not available. adapted in patchset 53. -
Benjamin Franzke commented on patch set 53 02/04/22, 22:08
ServiceProvider.php:209modulesFromPackages -
core-ci voted on patch set 53 V +1 02/04/22, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23024
-
Oli Bartsch uploaded patch set 54 02/04/22, 23:33
-
Oli Bartsch commented on patch set 54 02/04/22, 23:33
ServiceProvider.php:209ReplyDone -
core-ci voted on patch set 54 V -1 02/04/22, 23:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23026
-
Oli Bartsch uploaded patch set 55 02/04/22, 23:48
-
core-ci voted on patch set 55 V -1 02/04/22, 23:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23027
-
Oli Bartsch uploaded patch set 56 02/05/22, 00:02
-
core-ci voted on patch set 56 V +1 02/05/22, 00:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23028
-
Benjamin Franzke uploaded patch set 57 02/05/22, 07:00
-
core-ci voted on patch set 57 V +1 02/05/22, 07:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23034
-
Stefan Bürk uploaded patch set 58 02/06/22, 12:54
-
core-ci voted on patch set 58 V +1 02/06/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23096
-
Benni Mack voted on patch set 58 V +1 CR +1 02/07/22, 09:17
-
Christian Kuhn voted on patch set 58 V +1 CR +1 02/07/22, 09:27
-
Benni Mack commented on patch set 58 V +2 CR +2 02/07/22, 09:29
Thanks, a big change, finally (I've been wanting to do this for 5 years) -
Benni Mack merged patch set 59 02/07/22, 09:29
ModuleProvider.php:220