Review main Merged

73060[BUGFIX] Create module template early in PreviewController

Oli Bartsch CR +2 V +2 Easy +4 −2 updated 01/19/22, 12:19

Commit message

When creating the module template, also default CSS
and JS is added (using PageRenderer).

In the PreviewController, the loading order is important,
since module related properties are overwritten in a
custom CSS file (e.g. margins).

Therefore, the module creation is now moved to the top
of the method, which allows to override the default
styles again.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 01/19/22, 10:44

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 01/19/22, 10:56

  3. core-ci voted on patch set 1 V +1 01/19/22, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22253

  4. Christian Kuhn commented on patch set 1 01/19/22, 10:57

    note this is one of the few controllers after my controller-refactoring works, that still handles pageRenderer stuff on its own ... others do that in view templates. in this case, there is so much pageRenderer stuff going on, that it's hard to put it into templates, so i left it within controller for this one.
  5. Stefan Bürk voted on patch set 1 V +1 CR +1 01/19/22, 11:51

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 01/19/22, 12:19

  7. Oli Bartsch merged patch set 2 01/19/22, 12:19