Review main Merged

73061[BUGFIX] Fix undefined array key in StagesService

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 01/19/22, 12:18

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Michael Blunck +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Michael Blunck +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oli Bartsch uploaded patch set 1 01/19/22, 11:04

  2. Oli Bartsch updated the commit message in patch set 2 01/19/22, 11:07

  3. Christian Kuhn voted on patch set 2 V +1 CR +1 01/19/22, 11:08

  4. Oli Bartsch commented on patch set 2 01/19/22, 11:09

    StagesService.php:156

    Now the same as the condition in L:108.
  5. core-ci voted on patch set 1 V +1 01/19/22, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22257

  6. core-ci voted on patch set 2 V +1 01/19/22, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22259

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 01/19/22, 11:49

  8. Michael Blunck commented on patch set 2 V +1 CR +1 01/19/22, 11:52

    Works for me
  9. Oli Bartsch voted on patch set 2 V +2 CR +2 01/19/22, 12:18

  10. Oli Bartsch merged patch set 3 01/19/22, 12:18