Review main Merged

73063[TASK] Remove PHP < 8 specific libxml_disable_entity_loader()

Christian Kuhn CR +2 V +2 Normal +0 −149 updated 01/24/22, 11:00

Commit message

libxml bundled in PHP before 8.0 was suspectible
to XXE. The core mitigated this by setting
libxml_disable_entity_loader() at various places.

PHP >=8.0 bundles a libxml version that disables
external entity loading by default, method
libxml_disable_entity_loader() has been deprecated.

With TYPO3 v12 being PHP >= 8.1 only, these
method calls can be removed from the codebase.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 79

  1. Christian Kuhn uploaded patch set 1 01/19/22, 11:57

  2. Christian Kuhn updated the commit message in patch set 2 01/19/22, 11:57

  3. core-ci voted on patch set 2 V +1 01/19/22, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22262

  4. core-ci voted on patch set 1 V +1 01/19/22, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22261

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 01/19/22, 13:18

  6. Benni Mack voted on patch set 2 V +1 CR +1 01/19/22, 13:20

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 01/19/22, 14:08

  8. Christian Kuhn merged patch set 3 01/19/22, 14:09

  9. Oliver Hader voted on patch set 3 CR +1 01/24/22, 11:00