Review main Merged

73065[TASK] runTests.sh: Use sqlite by default for functionals

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 01/21/22, 11:02

Commit message

Change the default DBMS for functional tests in
runTests.sh from mariadb to sqlite: sqlite is
sigificantly quicker with functional tests and
thus the preferred DBMS selection when running
tests locally for us lazy devs since we can omit
the '-d sqlite' option now.

This has no impact on CI since the DBMS is
always explicitly set in gitlab-ci configs.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 01/19/22, 14:47

  2. Christian Kuhn voted on patch set 1 CR -1 01/19/22, 14:53

  3. core-ci voted on patch set 1 V +1 01/19/22, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22271

  4. Benjamin Franzke uploaded patch set 2 01/19/22, 15:06

  5. core-ci voted on patch set 2 V +1 01/19/22, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22274

  6. Benni Mack voted on patch set 2 V +1 CR +1 01/19/22, 15:33

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 01/19/22, 16:04

  8. Christian Kuhn commented on patch set 2 CR -1 01/19/22, 16:34

    -1 for the moment - we'll need to sort out a v11 issue first.
  9. Christian Kuhn commented on patch set 2 V +2 CR +2 01/21/22, 11:02

    Sorry for delay. I'll pick this patch for master as-is now and will have an adaption for v11 - one that can be eventually removed later again when v11 supports ac tests with sqlite.
  10. Christian Kuhn merged patch set 3 01/21/22, 11:02