73067[TASK] Remove some PHP < 8.1 specific code switches
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Resources/PHP/ClassMapGenerator.php3+2 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php+1 −5
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/EmailViewHelperTest.php+2 −14
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+4 −13
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+2 −14
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+0 −14
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+1 −1
Review log 1114
-
Christian Kuhn uploaded patch set 1 01/19/22, 15:19
-
core-ci voted on patch set 1 V -1 01/19/22, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22275
-
Oliver Klee commented on patch set 1 01/19/22, 15:22
-
Christian Kuhn commented on patch set 1 01/19/22, 15:24
ClassMapGenerator.php:123Replydidn't wanted to do this since the file is still a copy from composer (for whatever reasons), so i wanted to not do much in it in case this duplication is gonna resolved at some point again. -
Christian Kuhn uploaded patch set 2 01/19/22, 15:25
-
Christian Kuhn commented on patch set 2 01/19/22, 15:28
ClassMapGenerator.php:123Replybut in fact i don't care too much. if you prefer inlining, i'll do that. -
Christian Kuhn uploaded patch set 3 01/19/22, 15:30
-
core-ci voted on patch set 2 V +1 01/19/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22276
-
core-ci voted on patch set 3 V +1 01/19/22, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22277
-
Oliver Klee voted on patch set 3 CR +1 01/19/22, 15:44
-
Andreas Kienast voted on patch set 3 V +1 CR +1 01/19/22, 15:52
-
Stefan Bürk voted on patch set 3 V +1 CR +1 01/19/22, 16:13
-
Andreas Kienast voted on patch set 3 V +2 CR +2 01/19/22, 16:31
-
Andreas Kienast merged patch set 4 01/19/22, 16:31
ClassMapGenerator.php:123