Review main Merged

73067[TASK] Remove some PHP < 8.1 specific code switches

Christian Kuhn CR +2 V +2 Normal +12 −68 updated 01/19/22, 16:31

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1114

  1. Christian Kuhn uploaded patch set 1 01/19/22, 15:19

  2. core-ci voted on patch set 1 V -1 01/19/22, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22275

  3. Oliver Klee commented on patch set 1 01/19/22, 15:22

    ClassMapGenerator.php:123

    I think we can now inline the variable in line 140.
  4. Christian Kuhn commented on patch set 1 01/19/22, 15:24

    ClassMapGenerator.php:123 Reply

    didn't wanted to do this since the file is still a copy from composer (for whatever reasons), so i wanted to not do much in it in case this duplication is gonna resolved at some point again.
  5. Christian Kuhn uploaded patch set 2 01/19/22, 15:25

  6. Christian Kuhn commented on patch set 2 01/19/22, 15:28

    ClassMapGenerator.php:123 Reply

    but in fact i don't care too much. if you prefer inlining, i'll do that.
  7. Christian Kuhn uploaded patch set 3 01/19/22, 15:30

  8. core-ci voted on patch set 2 V +1 01/19/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22276

  9. core-ci voted on patch set 3 V +1 01/19/22, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22277

  10. Oliver Klee voted on patch set 3 CR +1 01/19/22, 15:44

  11. Andreas Kienast voted on patch set 3 V +1 CR +1 01/19/22, 15:52

  12. Stefan Bürk voted on patch set 3 V +1 CR +1 01/19/22, 16:13

  13. Andreas Kienast voted on patch set 3 V +2 CR +2 01/19/22, 16:31

  14. Andreas Kienast merged patch set 4 01/19/22, 16:31