73070[BUGFIX] Toggle cropper on focus area interaction
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Jörg Bösche +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 913
-
Andreas Kienast uploaded patch set 1 01/19/22, 16:19
-
core-ci voted on patch set 1 V +1 01/19/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22281
-
Jörg Bösche commented on patch set 1 CR -1 01/20/22, 10:07
The patch doesnt work for my current installation. T3 v11.5.6. Chrome console error: ``` ImageManipulation.js?bust=1642673036:13 Uncaught TypeError: this.focusArea.addEventListener is not a function at HTMLDivElement.create (ImageManipulation.js?bust=1642673036:13:9139) at t.<computed>.<computed>._trigger (widget.js?bust=1642673036:11:6138) at t.<computed>.<computed>._trigger (draggable.js?bust=1642673036:11:11587) at t.<computed>.<computed>.t.each.t.isFunction.u.<computed> [as _trigger] (widget.js?bust=1642673036:11:992) at t.<computed>.<computed>._createWidget (widget.js?bust=1642673036:11:3063) at new t.<computed>.<computed> (widget.js?bust=1642673036:11:589) at HTMLDivElement.<anonymous> (widget.js?bust=1642673036:11:2319) at Function.each (jquery.js?bust=1642673036:385:19) at jQuery.fn.init.each (jquery.js?bust=1642673036:207:17) at jQuery.fn.init.t.fn.<computed> [as draggable] (widget.js?bust=1642673036:11:2228) ``` -
Andreas Kienast uploaded patch set 2 01/21/22, 08:09
-
core-ci voted on patch set 2 V -1 01/21/22, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22333
-
core-ci voted on patch set 2 V +1 01/21/22, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22333
-
Andreas Kienast uploaded patch set 3 01/21/22, 09:27
-
Benjamin Franzke voted on patch set 3 V +1 CR +1 01/21/22, 09:39
-
core-ci voted on patch set 3 V +1 01/21/22, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22338
-
Jörg Bösche commented on patch set 3 V +1 01/21/22, 09:45
I am happy to say that it works like a charm. Thank you! Chrome 97.0.x TYPO3 CMS v11.5.6 -
Benni Mack voted on patch set 3 V +1 CR +1 01/21/22, 12:31
-
Andreas Kienast voted on patch set 3 V +2 CR +2 01/21/22, 12:34
-
Andreas Kienast merged patch set 4 01/21/22, 12:34