Review main Merged

73071[BUGFIX] Cleanup missed removal of unused variable in ShortcutController

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 01/19/22, 19:24

Commit message

ShortcutController has recieved an modernization overhaul
and shifted data changing actions from 'GET' and 'POST'
handling to 'POST' handling only through #96519, which
removed '$queryParameters' variable populated with 'GET'
parameters from the request in method 'addAction()'.

However removing usage of this variable in a value
fallback chain has been missed, which is now removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 01/19/22, 18:15

  2. core-ci voted on patch set 1 V +1 01/19/22, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22282

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 01/19/22, 18:51

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 01/19/22, 19:13

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 01/19/22, 19:24

  6. Christian Kuhn merged patch set 2 01/19/22, 19:24