Review 11.5 Merged

73081[BUGFIX] Revert behaviour of stdWrap ifEmpty

Benni Mack CR +2 V +2 Easy +45 −4 updated 01/20/22, 20:32

Commit message

The stdWrap function ifEmpty must return true if a
PHP falsy value is given. That means e.g. an empty
string or a "0".

To make it more clear that stdWrap ifEmpty in fact
uses the logic of the PHP function "empty", this
function is now used.

First, the value is trimmed, which means a string
is returned, and then this value is passed to the
empty function.

As this works now properly, the getCurrentValue
method needed a check against empty array keys. The
stdWrap_current method now uses the getCurrentValue
method as they both do the exact same thing.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 01/20/22, 19:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/20/22, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22317

  3. Benni Mack voted on patch set 1 V +2 CR +2 01/20/22, 20:32

  4. Benni Mack merged patch set 2 01/20/22, 20:32