Review 10.4 Merged

73087[BUGFIX] Replace properties correctly in Extbase Persistence Class overrides

Benni Mack CR +2 V +2 Easy +7 −8 updated 01/22/22, 12:14

Commit message

Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecursiveWithOverrule" was used in the wrong order.

This patch now uses "array_replace_recursive" and adds the
child properties at the very end.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack commented on patch set 1 01/22/22, 12:00

    Cherry Picked from branch 11.5. The following files contain Git conflicts: * typo3/sysext/extbase/Tests/Unit/Persistence/ClassesConfigurationFactoryTest.php
  2. Benni Mack commented on patch set 2 01/22/22, 12:02

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 01/22/22, 12:02

  4. core-ci voted on patch set 1 V -1 01/22/22, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22402

  5. core-ci voted on patch set 2 V +1 01/22/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22403

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/22/22, 12:14

  7. Benni Mack merged patch set 3 01/22/22, 12:14