Review 11.5 Merged

73091[BUGFIX] Prevent PHP warning in menu data processors

Benni Mack CR +2 V +2 Easy +13 −9 updated 01/24/22, 19:40

Commit message

Check if the decoded menu is iterable,
before passing it to "foreach".

Note: No early return is used, since
this would be a change in behaviour.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack commented on patch set 1 01/24/22, 19:18

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 01/24/22, 19:30

  3. core-ci voted on patch set 1 V +1 01/24/22, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22486

  4. Benni Mack voted on patch set 1 V +2 CR +2 01/24/22, 19:40

  5. Benni Mack merged patch set 2 01/24/22, 19:40