Review main Merged

73092[BUGFIX] Avoid reading value from undefined variable

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 01/19/22, 19:11

Commit message

Show columns selection functionality has been improved
for issue #94474, but during refactoring some code it
falsly tries to read the 'pageId' parameter from undefined
'$parsedBody' instead of the available variable $queryArguments,
which is used to pass to another method.

This patch now fetch the pageId from query arguments and remove
the usage of the undefined variable.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 01/19/22, 18:33

  2. core-ci voted on patch set 1 V +1 01/19/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22283

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 01/19/22, 18:53

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 01/19/22, 19:10

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 01/19/22, 19:11

  6. Christian Kuhn merged patch set 2 01/19/22, 19:11