Review main Merged

73093[BUGFIX] Keep defined order for menus of type list

Georg Ringer CR +2 V +2 Easy +16 −10 updated 01/20/22, 21:19

Commit message

If the special menu type 'list' is used, the order
must be kept as provided within the list configuration.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1113

  1. Georg Ringer uploaded patch set 1 01/19/22, 19:33

  2. Georg Ringer commented on patch set 1 01/19/22, 19:33

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 01/19/22, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22285

  4. Benni Mack commented on patch set 1 V +1 CR +1 01/19/22, 21:02

    THANKS, Georg
  5. Benni Mack commented on patch set 1 V 0 CR -2 01/19/22, 21:03

    Actually, I will modify tests to reflect this behavior.
  6. Benni Mack voted on patch set 1 CR 0 01/19/22, 21:47

  7. Oli Bartsch uploaded patch set 2 01/19/22, 21:55

  8. Oli Bartsch commented on patch set 2 V +1 CR +1 01/19/22, 21:56

    Reply

    Done
    Thanks Georg! I adjusted the tests and modified to way, the order is restored.
  9. core-ci voted on patch set 2 V +1 01/19/22, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22291

  10. Stefan Bürk commented on patch set 2 V +1 CR +1 01/19/22, 22:58

    Thanks Georg! And thanks Oliver for the test adjustments.
  11. Benni Mack voted on patch set 2 V +1 CR +1 01/20/22, 21:01

  12. Oli Bartsch voted on patch set 2 V +2 CR +2 01/20/22, 21:19

  13. Oli Bartsch merged patch set 3 01/20/22, 21:19