Review main Merged

73094[TASK] Use BackendTemplateView in ext:tstemplate

Christian Kuhn CR +2 V +2 Hard +223 −77 updated 01/19/22, 21:01

Commit message

This is a rather straight implementation of
BackendTemplateView in favor of StandaloneView
in ext:tstemplate - refactoring only necessary
parts: Template selection as argument to render(),
f:translate with full "LLL" keys, avoiding
f:form.* VH usages, not setting request to view
anymore.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 13

Review log 68

  1. Christian Kuhn uploaded patch set 1 01/19/22, 20:13

  2. core-ci voted on patch set 1 V -1 01/19/22, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22287

  3. Christian Kuhn uploaded patch set 2 01/19/22, 20:29

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 01/19/22, 20:48

  5. core-ci voted on patch set 2 V +1 01/19/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22288

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/19/22, 20:58

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 01/19/22, 21:00

  8. Christian Kuhn merged patch set 3 01/19/22, 21:01