Review main Merged

73096[BUGFIX] Replace undefined variable with reading PageTSConfig option

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 01/20/22, 11:01

Commit message

Long story short, through multiple refactorings along the road, from
the inital introduction of the 'mod.newContentElementWizard.override'
option with #70055 over streamlining the TSConfig api (#85016), a lot
of stations in between which already broke reading that option, which
was used for adding the 'new record button', this was refactored into
a dedicated 'createAddButtonForTable()' method with #94456, ending up
with even more broken code and leaving an undefined variable $tsConfig.

Instead of removing the unused variable we load the pageTs here to be
able to read this option again and restore the intended behaviour.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 4

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 01/19/22, 21:58

  2. core-ci voted on patch set 1 V +1 01/19/22, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22292

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 01/19/22, 22:51

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 01/20/22, 09:51

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 01/20/22, 11:01

  6. Oli Bartsch merged patch set 2 01/20/22, 11:01