Review main Merged

73098[BUGFIX] Avoid undefined array key 'casesensitiveComp'

Stefan Bürk CR +2 V +2 Easy +4 −1 updated 01/22/22, 12:34

Commit message

Using null coalescing operator with fallback to 'false'
to avoid undefined array key access warnings when key
'casesensitiveComp' is not set. Using 'false' here as
this matches the behaviour of <PHP8.0, and as this is
used as method argument of type bool a bool typecase
is added along the way to be on the safe side.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 01/19/22, 22:43

  2. Stefan Bürk commented on patch set 1 CR -1 01/19/22, 22:52

    just first try. This should avoid the "error" message. But maybe the option get kicked, which should be checked anyway.
  3. core-ci voted on patch set 1 V +1 01/19/22, 22:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22295

  4. Stefan Bürk wrote 01/21/22, 12:45

    Removed Code-Review-1 by Stefan Bürk <stefan@buerk.tech>
  5. Stefan Bürk rebased onto patch set 2 01/21/22, 12:45

  6. core-ci voted on patch set 2 V +1 01/21/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22350

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/21/22, 20:57

  8. Benni Mack voted on patch set 2 V +2 CR +2 01/22/22, 12:34

  9. Benni Mack merged patch set 3 01/22/22, 12:34