73099[TASK] Avoid TBE_EDITOR declaration via synchronous script tag
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineValidation.ts+1 −1
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+0 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/jsfunc.tbe_editor.jsdeleted+0 −20
Review log 1114
-
Benjamin Franzke uploaded patch set 1 01/20/22, 08:08
-
Benjamin Franzke commented on patch set 1 01/20/22, 08:10
Note: Can be tested by changing returnFieldJS() in typo3/sysext/redirects/Classes/Evaluation/SourceHost.php back to: public function returnFieldJS(): string { $jsCode = []; $jsCode[] = 'if (value === \'*\') {return value;}'; $jsCode[] = 'var parser = document.createElement(\'a\');'; $jsCode[] = 'parser.href = value.indexOf(\'://\') != -1 ? value : \'http://\'; + value;'; $jsCode[] = 'return parser.host;'; return implode(' ', $jsCode); } (As it has been prior https://review.typo3.org/c/Packages/TYPO3.CMS/+/72154 has been merged) -
Benjamin Franzke wrote 01/20/22, 08:10
Topic set to esm -
Benjamin Franzke commented on patch set 1 01/20/22, 08:12
I'm not aware that this breaks stuff, but I'd still rather do not backport to 11.5 as it might cause issues for some very legacy code that TBE_EDITOR is no longer declared by default. -
Benjamin Franzke uploaded patch set 2 01/20/22, 08:14
-
Benjamin Franzke commented on patch set 2 CR -1 01/20/22, 08:15
CR-1 until https://review.typo3.org/c/Packages/TYPO3.CMS/+/72637 is merged -
core-ci voted on patch set 1 V +1 01/20/22, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22299
-
core-ci voted on patch set 2 V +1 01/20/22, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22300
-
Benjamin Franzke uploaded patch set 3 01/21/22, 09:27
-
core-ci voted on patch set 3 V +1 01/21/22, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22337
-
Andreas Kienast voted on patch set 3 V +1 CR +1 01/21/22, 15:20
-
Benni Mack voted on patch set 3 V +1 CR +1 01/21/22, 15:57
-
Benjamin Franzke voted on patch set 3 V +2 CR +2 01/21/22, 15:58
-
Benjamin Franzke merged patch set 4 01/21/22, 15:58