Review 11.5 Abandoned

73100[WIP][FEATURE] Page module improvements patch for pilot package

Jonas Eberle CR 0 V 0 Hard +815 −155 updated 10/09/23, 11:59

Commit message

The patch simplifies and optimizes the readability of the page
module interface (column and language submodules), and add a
new content wizard bar to drag and drop new contents.

The colPos areas are visually simplified
A new btn-fab (floating action buttons) style is applied to the "add new
content" and "paste" buttons.
The drop zones are streamlined with the positions and style of the "add
new content" buttons.
The content element boxes and their header buttons are visually
simplified.
The language flag and title are removed from the content header and
the unecessary js relative to this html is removed as well. Instead,
when a content has the language -1 (All), this information is now
displayed in the content footer.
The content elements CType title is always shown beside the CType icon.
A new button for the content element context menu is added in the
content element header right button bar, in place of the delete button.
The content elements delete button is now inside the context menu
only.
The hidden content elements are now differenciated with a better opacity
and a dotted border.
A new content wizard bar list the same content types like the modal
wizard, but in a vertical bar with accordions.
When the editor drops the content in a drop zone, the content is
directly inserted without opening the content form.
The content is hidden by default.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 20

Review log 1214

  1. Jonas Eberle uploaded patch set 1 01/20/22, 09:43

  2. core-ci voted on patch set 1 V -1 01/20/22, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22301

  3. Stefan Bürk commented on patch set 1 01/21/22, 12:44

    Is this a backport of https://review.typo3.org/c/Packages/TYPO3.CMS/+/71965 ? Looks really similar, and at least same resolve lines ... just changed release lines ? Was this intended ? And why not as cherry-pick / backport ? I'm little bit confused witch that ...
  4. Jonas Eberle commented on patch set 1 01/21/22, 12:51

    Yes, this was intended like that. Some in the structured content initiative want to maintain https://github.com/TYPO3-Initiatives/structured-content-page-module for v11 so we needed a base. Sorry, I expected some confusion but it has been green-lighted by Benni to go ahead with pushing a separate v11-patch to Gerrit.
  5. Stefan Bürk commented on patch set 1 01/21/22, 16:14

    Reply

    Okay, thanks for solving my confussion knot. And not it is documented, also Benni's green light for that.
  6. André Kraus voted on patch set 1 V +1 01/24/22, 19:47

  7. André Kraus wrote 01/24/22, 19:47

    Removed Verified+1 by André Kraus <info@andrekraus.com>
  8. Annett Jähnichen voted on patch set 1 V +1 01/24/22, 19:53

  9. Stefan Bürk wrote 01/26/22, 02:02

    Removed cc Stefan Bürk.
  10. Jonas Eberle marked it work in progress 02/08/22, 09:17

  11. Jonas Eberle uploaded patch set 2 02/08/22, 09:24

  12. Jonas Eberle commented on patch set 2 02/08/22, 09:25

    Just rebased for 11.5.6
  13. core-ci voted on patch set 2 V -1 02/08/22, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23200

  14. Jonas Eberle abandoned the change 10/09/23, 11:59