Review 10.4 Merged

73102[BUGFIX] Prevent null pointer in PageLayoutView

Oli Bartsch CR +2 V +2 Easy +5 −2 updated 01/20/22, 16:25

Commit message

Under some circumstances, e.g. in a translations
only page module, a given $languageId (in this case
the default `0`) is not part of the $siteLanguages
array, since this only contains languages, allowed
for the user.

To fix a null pointer exception, we check whether
the SiteLanguage exists, before accessing it.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 01/20/22, 12:48

  2. core-ci voted on patch set 1 V +1 01/20/22, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22305

  3. Benni Mack voted on patch set 1 V +1 CR +1 01/20/22, 13:21

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 01/20/22, 14:21

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 01/20/22, 16:25

  6. Oli Bartsch merged patch set 2 01/20/22, 16:25