73104[BUGFIX] Remove undefined variable in extensionmanager ListUtility
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Simon Gilli +1
-
Verified V +2 Done
- Helmut Hummel +2
- Simon Gilli +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1519
-
Stefan Bürk uploaded patch set 1 01/20/22, 14:06
-
core-ci voted on patch set 1 V +1 01/20/22, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22307
-
Simon Gilli commented on patch set 1 V +1 CR +1 01/20/22, 14:39
Thanks! -
Helmut Hummel commented on patch set 1 V -1 01/20/22, 15:55
State from ext_emconf is currently never taken into account when listing. Maybe we should fix this somehow. -
Helmut Hummel commented on patch set 1 01/20/22, 16:03
ListUtility.php:212add this line here: $extensions[$extensionKey]['state'] = $emConf['state'] ?? $extensions[$extensionKey]['state'] ?? 'stable'; To respect the state from ext_emconf.php if it is given. another option would be to transfer both to package meta data (like done for extension title) and always pull the state from there. -
Stefan Bürk commented on patch set 1 01/20/22, 16:28
ListUtility.php:212ReplyAs I'm not into this topic, and created this to remove the unused variable and your comment on the related patch, may I ask if one of you both may take over this patch if there is more to do ? Or let me know what to do (eventually on slack). -
Stefan Bürk commented on patch set 1 01/20/22, 16:29
ListUtility.php:212ReplyAh misread .. will add this ... -
Stefan Bürk uploaded patch set 2 01/20/22, 16:32
-
Stefan Bürk commented on patch set 2 01/20/22, 16:33
ListUtility.php:212ReplyAdded, hopefully on the correct place. -
core-ci voted on patch set 2 V -1 01/20/22, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22311
-
Stefan Bürk commented on patch set 2 01/20/22, 16:56
ListUtility.php:212ReplyAdding this line fails unit tests. Should tests be adjusted - or rething this line / solution ? -
Stefan Bürk uploaded patch set 3 01/21/22, 19:15
-
core-ci voted on patch set 3 V +1 01/21/22, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22371
-
Stefan Bürk rebased onto patch set 4 01/24/22, 19:08
-
core-ci voted on patch set 4 V +1 01/24/22, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22485
-
Simon Gilli voted on patch set 4 V +1 CR +1 01/24/22, 19:59
-
Stefan Bürk commented on patch set 4 01/25/22, 06:47
ListUtility.php:212ReplyDone -
Helmut Hummel voted on patch set 4 V +2 CR +2 01/25/22, 09:23
-
Helmut Hummel merged patch set 5 01/25/22, 09:23