Review main Merged

73105[TASK] Use native TYPO3Fluid view in ext:seo frontend

Christian Kuhn CR +2 V +2 Normal +20 −34 updated 01/21/22, 13:07

Commit message

To demonstrate it's possible to use the native
TYPO3 "standalone" Fluid TemplateView in the frontend,
the patch changes the ext:seo frontend sitemap XML
rendering to use TYPO3Fluid TemplateView instead of
ext:fluid StandaloneView.
This means the view does not receive a request anymore
and needs to be set up in a slightly different way,
which in turn avoids depedencies to extbase for this
non-extbase based plugin.
The extbase specific f:uri.page ViewHelper usage is
thus changed to f:uri.typolink in the templates.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Christian Kuhn uploaded patch set 1 01/20/22, 14:24

  2. core-ci voted on patch set 1 V +1 01/20/22, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22308

  3. Oliver Klee commented on patch set 1 01/20/22, 16:17

    Typo: TYPO3FLuid -> TYPO3Fluid
  4. Stefan Bürk updated the commit message in patch set 2 01/21/22, 10:22

  5. Stefan Bürk commented on patch set 2 01/21/22, 10:23

    Reply

    Done
  6. Oliver Klee wrote 01/21/22, 10:31

    Removed cc Oliver Klee.
  7. core-ci voted on patch set 2 V +1 01/21/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22343

  8. Christian Kuhn uploaded patch set 3 01/21/22, 12:18

  9. Benni Mack voted on patch set 3 V +1 CR +1 01/21/22, 12:30

  10. core-ci voted on patch set 3 V +1 01/21/22, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22348

  11. Benjamin Franzke voted on patch set 3 CR +1 01/21/22, 12:31

  12. Stefan Bürk voted on patch set 3 V +1 CR +1 01/21/22, 12:35

  13. Andreas Kienast voted on patch set 3 CR +1 01/21/22, 12:46

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 01/21/22, 13:07

  15. Christian Kuhn merged patch set 4 01/21/22, 13:07