Review main Merged Breaking

73107[!!!][TASK] Remove deprecated ModuleTemplate->addJavaScriptCode()

Christian Kuhn CR +2 V +2 Normal +49 −35 updated 01/21/22, 13:24

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1214

  1. Christian Kuhn uploaded patch set 1 01/20/22, 16:39

  2. core-ci voted on patch set 1 V +1 01/20/22, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22312

  3. Stefan Bürk commented on patch set 1 V +1 CR +1 01/20/22, 16:53

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:88

    Is this added to be nice even if it was marked as an internal method which should not need a breaking rst ? Anyway does not hurt to add it here, just questioning to learn something ....
  4. Benjamin Franzke commented on patch set 1 01/20/22, 17:17

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:88 Reply

    Hm.. it has been marked as @internal in v11.5.3 with https://review.typo3.org/c/Packages/TYPO3.CMS/+/64123/23/typo3/sysext/backend/Classes/Template/ModuleTemplate.php and therefore never received a real deprecation as the patch was authored after 11.5.0 had been released. So probably better to list it here than nowhere, but I think in theory it should have an own Breaking.rst to differentiate from breaking changes for deprecated code. (I know, feels like too much boilerplate for one such function, but maybe we could at least add it to the extension scanner?)
  5. Christian Kuhn commented on patch set 1 01/20/22, 17:26

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:88 Reply

    will take care.
  6. Christian Kuhn voted on patch set 1 CR -1 01/20/22, 17:26

  7. Christian Kuhn commented on patch set 1 01/21/22, 12:29

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:88 Reply

    I've seen the situation ... it's a pity we have no proper deprecation file in v11 (and it's a bit late, probably does not make that much sense to still add it). And I've been a bit lazy with this patch to not add a breaking.rst now. I'll come up with a dedicated breaking.rst together with a scanner entry.
  8. Christian Kuhn uploaded patch set 2 01/21/22, 12:58

  9. core-ci voted on patch set 2 V +1 01/21/22, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22351

  10. Benjamin Franzke voted on patch set 2 V +1 CR +1 01/21/22, 13:23

  11. Benjamin Franzke wrote 01/21/22, 13:23

    Topic set to inline-javascript
  12. Stefan Bürk voted on patch set 2 V +1 CR +1 01/21/22, 13:24

  13. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/21/22, 13:24

  14. Benjamin Franzke merged patch set 3 01/21/22, 13:24