Review main Merged

73108[BUGFIX] Hide view page button in special all languages view

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 01/20/22, 21:00

Commit message

The "View webpage" button in the docheader of the
page module allows to view the page in the currently
selected language. This means, the button always
depends on the selected language.

With #92460 the special "all languages" option was
added to the language selector (in languages mode).

Since this option is no valid language id, the button
is now hidden, in case "All languages" is selected.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 01/20/22, 16:41

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 01/20/22, 16:47

  3. core-ci voted on patch set 1 V +1 01/20/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22313

  4. Benni Mack voted on patch set 1 V +1 CR +1 01/20/22, 18:11

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 01/20/22, 21:00

  6. Oli Bartsch merged patch set 2 01/20/22, 21:00