Review main Merged

73109[TASK] Use BackendTemplateView in various controllers

Christian Kuhn CR +2 V +2 Expert +1173 −1234 updated 01/21/22, 10:27

Commit message

This goes through a series of relatively simple
controllers, switching them to BackendTemplateView.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 78

Show 58 more files

Review log 1623

  1. Christian Kuhn uploaded patch set 1 01/20/22, 18:36

  2. core-ci voted on patch set 1 V -1 01/20/22, 18:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22315

  3. Christian Kuhn uploaded patch set 2 01/20/22, 19:46

  4. Benjamin Franzke commented on patch set 2 01/20/22, 19:50

    RecoveryCodesProvider.php:35

    MFA providers were supposed to be backend/frontend agnostic, we shouldn't use a backend template view here (or a backend oriented factory later on).
  5. core-ci voted on patch set 2 V -1 01/20/22, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22318

  6. Christian Kuhn commented on patch set 2 01/20/22, 19:59

    RecoveryCodesProvider.php:35 Reply

    good point. will revert these.
  7. Christian Kuhn uploaded patch set 3 01/20/22, 20:25

  8. core-ci voted on patch set 3 V +1 01/20/22, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22319

  9. Christian Kuhn uploaded patch set 4 01/20/22, 22:07

  10. Christian Kuhn uploaded patch set 5 01/20/22, 22:07

  11. core-ci voted on patch set 5 V -1 01/20/22, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22323

  12. Christian Kuhn uploaded patch set 6 01/20/22, 22:30

  13. core-ci voted on patch set 6 V +1 01/20/22, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22324

  14. Christian Kuhn uploaded patch set 7 01/21/22, 00:18

  15. core-ci voted on patch set 7 V +1 01/21/22, 00:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22327

  16. Christian Kuhn updated the commit message in patch set 8 01/21/22, 00:41

  17. core-ci voted on patch set 8 V +1 01/21/22, 00:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22328

  18. Benni Mack voted on patch set 8 CR +1 01/21/22, 07:29

  19. Stefan Bürk voted on patch set 8 CR +1 01/21/22, 08:05

  20. Benni Mack voted on patch set 8 V +1 01/21/22, 09:17

  21. Stefan Bürk voted on patch set 8 V +1 01/21/22, 09:54

  22. Christian Kuhn voted on patch set 8 V +2 CR +2 01/21/22, 10:27

  23. Christian Kuhn merged patch set 9 01/21/22, 10:27