Review main Merged

73111[TASK] Ensure requirejs-loader.js and JavaScriptItemHandler.js are cache invalidatable

Benjamin Franzke CR +2 V +2 Easy +8 −6 updated 01/27/22, 18:19

Commit message

If compression of JavaScript files is disabled, we need to add cache
busting parameters to any backend JavaScript resource, in order to
be able to force browsers to re-download these files on updates.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1215

  1. Benjamin Franzke uploaded patch set 1 01/21/22, 07:58

  2. Benjamin Franzke wrote 01/21/22, 08:02

    Topic set to esm
  3. core-ci voted on patch set 1 V -1 01/21/22, 08:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22332

  4. Benjamin Franzke uploaded patch set 2 01/21/22, 08:21

  5. core-ci voted on patch set 2 V +1 01/21/22, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22334

  6. Benni Mack voted on patch set 2 V +1 CR +1 01/21/22, 08:45

  7. Andreas Kienast commented on patch set 2 CR -1 01/21/22, 09:07

    PageRenderer.php:2618

    This comment mismatches now, I've talked to Benjamin about this already
  8. Benjamin Franzke uploaded patch set 3 01/21/22, 09:08

  9. Benjamin Franzke commented on patch set 3 01/21/22, 09:08

    PageRenderer.php:2618 Reply

    ack, done.
  10. Andreas Kienast voted on patch set 3 V +1 CR +1 01/21/22, 09:10

  11. Benni Mack voted on patch set 3 V +1 CR +1 01/21/22, 09:11

  12. core-ci voted on patch set 3 V +1 01/21/22, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22335

  13. Benjamin Franzke voted on patch set 3 V +2 CR +2 01/21/22, 09:22

  14. Benjamin Franzke merged patch set 4 01/21/22, 09:22

  15. Benjamin Franzke wrote 01/27/22, 18:19

    Created a revert of this change as Iab2095823f32eecb972589b3c13a3e38c1f1709b