73111[TASK] Ensure requirejs-loader.js and JavaScriptItemHandler.js are cache invalidatable
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1215
-
Benjamin Franzke uploaded patch set 1 01/21/22, 07:58
-
Benjamin Franzke wrote 01/21/22, 08:02
Topic set to esm -
core-ci voted on patch set 1 V -1 01/21/22, 08:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22332
-
Benjamin Franzke uploaded patch set 2 01/21/22, 08:21
-
core-ci voted on patch set 2 V +1 01/21/22, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22334
-
Benni Mack voted on patch set 2 V +1 CR +1 01/21/22, 08:45
-
Andreas Kienast commented on patch set 2 CR -1 01/21/22, 09:07
PageRenderer.php:2618This comment mismatches now, I've talked to Benjamin about this already -
Benjamin Franzke uploaded patch set 3 01/21/22, 09:08
-
Benjamin Franzke commented on patch set 3 01/21/22, 09:08
PageRenderer.php:2618Replyack, done. -
Andreas Kienast voted on patch set 3 V +1 CR +1 01/21/22, 09:10
-
Benni Mack voted on patch set 3 V +1 CR +1 01/21/22, 09:11
-
core-ci voted on patch set 3 V +1 01/21/22, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22335
-
Benjamin Franzke voted on patch set 3 V +2 CR +2 01/21/22, 09:22
-
Benjamin Franzke merged patch set 4 01/21/22, 09:22
-
Benjamin Franzke wrote 01/27/22, 18:19
Created a revert of this change as Iab2095823f32eecb972589b3c13a3e38c1f1709b