Review 11.5 Merged

73113[TASK] runTests.sh: Use sqlite by default for functionals

Christian Kuhn CR +2 V +2 Easy +11 −5 updated 01/21/22, 11:57

Commit message

Change the default DBMS for functional tests in
runTests.sh from mariadb to sqlite: sqlite is
sigificantly quicker with functional tests and
thus the preferred DBMS selection when running
tests locally for us lazy devs since we can omit
the '-d sqlite' option now.

This has no impact on CI since the DBMS is
always explicitly set in gitlab-ci configs.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 01/21/22, 11:19

  2. Christian Kuhn voted on patch set 1 CR -1 01/21/22, 11:30

  3. core-ci voted on patch set 1 V +1 01/21/22, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22345

  4. Christian Kuhn commented on patch set 1 V +2 CR +2 01/21/22, 11:56

    note sqlite for ac tests in v11 is possible and needs releases and raises of testing-framework and styleguide ... we'll take care in a separate patch and will adapt runTests.sh then again.
  5. Christian Kuhn merged patch set 2 01/21/22, 11:57