Review main Merged

73119[TASK] Update PHP Parser to the latest release.

crell CR +2 V +2 Easy +10 −10 updated 01/24/22, 09:49

Commit message

The current version of PHP Parser we're using doesn't support
all the new PHP 8.1 syntax yet.  So update it.

Used commands:
composer req "nikic/php-parser":"^4.13.2"
composer req "nikic/php-parser":"^4.13.2" \
  -d typo3/sysext/core --no-update
composer req "nikic/php-parser":"^4.13.2" \
  -d typo3/sysext/install --no-update

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2026

Show 1 earlier messages
  1. crell uploaded patch set 1 01/21/22, 17:06

  1. core-ci voted on patch set 1 V -1 01/21/22, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22364

  2. crell uploaded patch set 2 01/21/22, 17:41

  3. core-ci voted on patch set 2 V +1 01/21/22, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22365

  4. Stefan Bürk updated the commit message in patch set 3 01/21/22, 17:59

  5. Stefan Bürk updated the commit message in patch set 4 01/21/22, 17:59

  6. crell voted on patch set 4 CR +1 01/21/22, 18:09

  7. core-ci voted on patch set 3 V +1 01/21/22, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22366

  8. core-ci voted on patch set 4 V +1 01/21/22, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22367

  9. Oliver Klee voted on patch set 4 CR +1 01/21/22, 18:30

  10. Christian Kuhn commented on patch set 4 01/21/22, 18:50

    composer.lock:8340

    why is that downgraded?
  11. Stefan Bürk uploaded patch set 5 01/21/22, 18:57

  12. Stefan Bürk commented on patch set 5 01/21/22, 19:00

    composer.lock:8340 Reply

    Maybe because of used composer 2.1.x ? Pushed redo with composer 2.2.4 without having this change. Anyway, composer.json sais ^2.1 ... and this is the lock file, maybe it's just a info with which composer version last lockfile was updated, and not as a req check or something like that ?
  13. core-ci voted on patch set 5 V +1 01/21/22, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22369

  14. Christian Kuhn commented on patch set 5 01/21/22, 19:26

    composer.lock:8340 Reply

    yeah, guess so, too. thx!
  15. Christian Kuhn commented on patch set 5 01/21/22, 19:27

    btw: we should test if extension scanner is still happy (i think it has little to no ac test coverage, yet, only a bunch of unit tests for matchers).
  16. Benni Mack commented on patch set 5 01/22/22, 12:13

    Should we also do this for 11.5 then?
  17. Oliver Klee voted on patch set 5 CR +1 01/22/22, 13:08

  18. Stefan Bürk commented on patch set 5 01/22/22, 18:31

    Reply

    Think that's a valid point. Cannot do that until Sunday evening ....

    Reply

    I would say, if we checked scanner like lollie mentioned, and it works we should check that for 11.5 to ... and raising this as backport too. Especially because this is not a dev dependency. What else does use this library in the core ? Only the scanner or something else ? Which 3rd party compomponents may use it ?
  19. Oliver Hader voted on patch set 5 CR +1 01/24/22, 08:21

  20. Oliver Hader updated the commit message in patch set 6 01/24/22, 08:23

  21. Oliver Hader commented on patch set 6 CR +1 01/24/22, 08:26

    PHP Parser should be fine for the AST classes we use. On the resolving part, probably `NameResolver` should be verified concerning `namespacedName`..
  22. core-ci voted on patch set 6 V +1 01/24/22, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22444

  23. Oliver Hader commented on patch set 6 V +1 01/24/22, 09:38

    No namespace-specific values of `NameResolver` are used in our code...
  24. Christian Kuhn voted on patch set 6 V +2 CR +2 01/24/22, 09:49

  25. Christian Kuhn merged patch set 7 01/24/22, 09:49