73120[TASK] Swap ReturnTypeWillChange attributes for proper return types.
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 18
- typo3/sysext/adminpanel/Classes/ModuleApi/ModuleDataStorageCollection.php+1 −7
- typo3/sysext/backend/Classes/Tree/SortedTreeNodeCollection.php+1 −3
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php+6 −18
- typo3/sysext/core/Classes/Log/LogRecord.php+4 −8
- typo3/sysext/core/Classes/Messaging/FlashMessageQueue.php+1 −4
- typo3/sysext/core/Classes/Resource/Collection/AbstractFileCollection.php+1 −3
- typo3/sysext/core/Classes/Resource/Search/Result/EmptyFileSearchResult.php+2 −5
- typo3/sysext/core/Classes/Resource/MetaDataAspect.php+4 −8
- typo3/sysext/core/Classes/Routing/PageArguments.php+4 −13
- typo3/sysext/core/Classes/Routing/SiteRouteResult.php+3 −16
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php+2 −4
- typo3/sysext/extbase/Classes/Persistence/Generic/QueryResult.php+11 −35
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+11 −21
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractCompositeValidator.php+1 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/ArrayAccessClass.php+2 −6
- typo3/sysext/form/Classes/Domain/Finishers/FinisherVariableProvider.php+2 −6
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+1 −4
- typo3/sysext/install/Classes/Service/Session/FileSessionHandler.php+5 −11
Review log 45
-
crell uploaded patch set 1 01/21/22, 18:42
-
core-ci voted on patch set 1 V -1 01/21/22, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22368
-
Stefan Bürk commented on patch set 1 CR -1 01/21/22, 19:03
Had this on the todo also. Question was open how to communitcate this, adding it to the central deprecation rst or have a new collecting rst or split this up to concerns. Anyway many of these are breaking, so -1 for now until we know how to handle this. -
Stefan Bürk commented on patch set 1 01/21/22, 19:05
Anyway, changing this needs to make sure all extneding class can handle it too. So maybe it should be splitted anyway. -
crell abandoned the change 01/25/22, 15:44
Stefan and loli are going to do this more piecemeal.