Review main Abandoned

73120[TASK] Swap ReturnTypeWillChange attributes for proper return types.

crell CR 0 V 0 Normal +62 −175 updated 01/25/22, 15:44

Commit message

This covers most, but not quite all, #[ReturnTypeWillChange] attributes.
There are few whose comments indicate the need for a bit more work
(such as removing a whole now-vestigial interface), which I left for
follow-ups to keep this simple.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 18

Review log 45

  1. crell uploaded patch set 1 01/21/22, 18:42

  2. core-ci voted on patch set 1 V -1 01/21/22, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22368

  3. Stefan Bürk commented on patch set 1 CR -1 01/21/22, 19:03

    Had this on the todo also. Question was open how to communitcate this, adding it to the central deprecation rst or have a new collecting rst or split this up to concerns. Anyway many of these are breaking, so -1 for now until we know how to handle this.
  4. Stefan Bürk commented on patch set 1 01/21/22, 19:05

    Anyway, changing this needs to make sure all extneding class can handle it too. So maybe it should be splitted anyway.
  5. crell abandoned the change 01/25/22, 15:44

    Stefan and loli are going to do this more piecemeal.