Review main Merged

73121[BUGFIX] Simulate usergroup in FE previews for restricted pages

Benni Mack CR +2 V +2 Easy +8 −10 updated 01/25/22, 06:35

Commit message

This change also sets a "userGroups" record for a
simulated user group, and also the user, in order
to build a proper usergroup information, this way, the
FE preview also works for restricted pages, because
the userAspect is evaluated properly.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2

Issues 1

Files 1

Review log 1216

  1. Benni Mack uploaded patch set 1 01/21/22, 21:22

  2. core-ci voted on patch set 1 V +1 01/21/22, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22379

  3. Stefan Bürk commented on patch set 1 01/24/22, 19:07

    PreviewSimulator.php:125

    Would suggest to add this and related request attributes to `.phpstorm.meta.php`, eventually in a dedicated (pre-)patch - and avoid adding doc-block comment here. Or would anything speak against it ? Anyway, no blocker at all - just mentioning it.
  4. Benni Mack commented on patch set 1 01/24/22, 19:32

    PreviewSimulator.php:125 Reply

    I think this would also be helpful for normalizedParams and site etc?
  5. Stefan Bürk commented on patch set 1 01/24/22, 19:49

    PreviewSimulator.php:125 Reply

    Yes, that was what I meant. Will came up with a dedicated patch for this, I think this would improve this and other cased and eliminates the need of docblock comments in code, like this.
  6. Stefan Bürk commented on patch set 1 01/24/22, 21:04

    PreviewSimulator.php:125 Reply

    Added dedicated patch for it: 73144: [TASK] Extend .phpstorm.meta.php for further autocompletion support | https://review.typo3.org/c/Packages/TYPO3.CMS/+/73144
  7. Stefan Bürk uploaded patch set 2 01/24/22, 21:19

  8. core-ci voted on patch set 2 V +1 01/24/22, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22491

  9. Oli Bartsch uploaded patch set 3 01/24/22, 23:42

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 01/24/22, 23:42

  11. Stefan Bürk voted on patch set 3 V +1 CR +1 01/24/22, 23:43

  12. core-ci voted on patch set 3 V +1 01/24/22, 23:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22493

  13. Georg Ringer updated the commit message in patch set 4 01/25/22, 06:20

  14. Georg Ringer voted on patch set 4 V +2 CR +2 01/25/22, 06:20

  15. Georg Ringer merged patch set 5 01/25/22, 06:21

  16. core-ci voted on patch set 4 V +1 01/25/22, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22499