Review main Merged

73122[BUGFIX] Avoid PHP warning in Extbase Workspace Overlays

Benni Mack CR +2 V +2 Easy +8 −6 updated 01/22/22, 11:50

Commit message

Due to the fact that PageRepository->getRawRecord()
can return an array OR 0 (int) Typo3DbBackend must check
for an array in order to avoid a PHP warning.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 01/21/22, 21:29

  2. core-ci voted on patch set 1 V +1 01/21/22, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22380

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 01/21/22, 23:52

  4. Stefan Bürk voted on patch set 1 CR +1 01/21/22, 23:57

  5. Stefan Bürk voted on patch set 1 V +1 01/22/22, 00:08

  6. Benni Mack voted on patch set 1 V +2 CR +2 01/22/22, 11:50

  7. Benni Mack merged patch set 2 01/22/22, 11:50