Review 11.5 Merged

73126[TASK] Avoid inline-javascript in InstallTool ExtensionConfiguration

Benjamin Franzke CR +2 V +2 Easy +15 −4 updated 01/28/22, 10:50

Commit message

ExtensionConfiguration uses inline JavaScript for the ColorPicker
initialization. Move the ColorPicker initialization into the
ExtensionConfiguration management module.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 89

  1. Benjamin Franzke uploaded patch set 1 01/22/22, 06:38

  2. core-ci voted on patch set 1 V +1 01/22/22, 06:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22398

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/22/22, 19:27

  4. Benjamin Franzke voted on patch set 1 V 0 CR 0 01/22/22, 19:28

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 01/22/22, 19:30

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/22/22, 19:31

  7. Benjamin Franzke merged patch set 2 01/22/22, 19:31

  8. Oliver Hader wrote 01/28/22, 10:50

    Topic set to inline-javascript
  9. Oliver Hader voted on patch set 2 CR +1 01/28/22, 10:50