73129[TASK] Avoid misusing ModuleTemplate in BackendController
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Controller/BackendController.php+138 −224
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+59 −190
- typo3/sysext/backend/Classes/Template/ModuleTemplateFactory.php+7 −11
- typo3/sysext/backend/Classes/Template/PageRendererBackendSetupTrait.phpnew+148 −0
- typo3/sysext/backend/Resources/Private/Partials/Backend/ModuleMenu.htmlnew+71 −0
- typo3/sysext/backend/Resources/Private/Partials/Backend/Topbar.htmlnew+71 −0
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+34 −2
- typo3/sysext/backend/Resources/Private/Templates/Backend/ModuleMenu.html+4 −66
- typo3/sysext/backend/Resources/Private/Templates/Backend/Topbar.html+6 −47
Review log 913
-
Christian Kuhn uploaded patch set 1 01/22/22, 22:32
-
Christian Kuhn uploaded patch set 2 01/22/22, 22:35
-
core-ci voted on patch set 2 V +1 01/22/22, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22419
-
core-ci voted on patch set 1 V +1 01/22/22, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22418
-
Christian Kuhn updated the commit message in patch set 3 01/22/22, 22:51
-
core-ci voted on patch set 3 V +1 01/22/22, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22420
-
Christian Kuhn commented on patch set 3 CR -1 01/23/22, 12:04
i'll change a detail so that the trait does not fetch dependencies from elsewhere but receives everything as argument. -
Christian Kuhn uploaded patch set 4 01/23/22, 12:08
-
core-ci voted on patch set 4 V +1 01/23/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22430
-
Benni Mack commented on patch set 4 V +1 CR +1 01/24/22, 07:07
I think this is a good compromise with the trait. -
Stefan Bürk voted on patch set 4 V +1 CR +1 01/24/22, 09:30
-
Christian Kuhn voted on patch set 4 V +2 CR +2 01/24/22, 09:38
-
Christian Kuhn merged patch set 5 01/24/22, 09:38