Review main Merged

73131[BUGFIX] Add missing boolean case to admin panel

Susi Moog CR +2 V +2 Easy +9 −0 updated 01/25/22, 06:14

Commit message

When dumping table data, the admin panel formats values
dependent on their type. The boolean type was missing
resulting in handling booleans as string and trying to
translate them. The missing case has been added and the
formatting adjusted to avoid displaying booleans as string
casted numbers.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1518

  1. Susi Moog uploaded patch set 1 01/23/22, 08:41

  2. core-ci voted on patch set 1 V +1 01/23/22, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22426

  3. Susi Moog updated the commit message in patch set 2 01/23/22, 08:59

  4. core-ci voted on patch set 2 V +1 01/23/22, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22427

  5. Oliver Klee voted on patch set 2 CR +1 01/23/22, 09:42

  6. Christian Kuhn commented on patch set 2 01/23/22, 10:07

    this is a v12 side effect of making translate VH strict_types=1 in #96473
  7. Christian Kuhn updated the commit message in patch set 3 01/23/22, 10:08

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 01/23/22, 10:09

  9. Georg Ringer commented on patch set 3 01/23/22, 10:10

    TableKeyValue.html:35

    we could skip the spaceless by just using {f:if(condition:val,then:'true',else:'false')}
  10. Christian Kuhn voted on patch set 3 V 0 CR 0 01/23/22, 10:12

  11. core-ci voted on patch set 3 V +1 01/23/22, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22428

  12. Susi Moog commented on patch set 3 01/23/22, 11:43

    Reply

    yes, but it's good that it's now stricter, so we actually see what is missing ;)

    TableKeyValue.html:35 Reply

    I find it a lot more readable like this, as string true/false in a condition tend to be confusing, but I'm fine with both ways.
  13. Oliver Klee voted on patch set 3 CR +1 01/23/22, 11:44

  14. Christian Kuhn commented on patch set 3 V +1 CR +1 01/23/22, 11:52

    TableKeyValue.html:35 Reply Unresolved

    i can live with both and will vote the patch +1 as is.
  15. Oliver Hader voted on patch set 3 CR +1 01/24/22, 07:41

  16. Stefan Bürk voted on patch set 3 V +1 CR +1 01/24/22, 19:00

  17. Christian Kuhn voted on patch set 3 V +2 CR +2 01/25/22, 06:14

  18. Christian Kuhn merged patch set 4 01/25/22, 06:14