73131[BUGFIX] Add missing boolean case to admin panel
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- Oliver Hader +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1518
-
Susi Moog uploaded patch set 1 01/23/22, 08:41
-
core-ci voted on patch set 1 V +1 01/23/22, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22426
-
Susi Moog updated the commit message in patch set 2 01/23/22, 08:59
-
core-ci voted on patch set 2 V +1 01/23/22, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22427
-
Oliver Klee voted on patch set 2 CR +1 01/23/22, 09:42
-
Christian Kuhn commented on patch set 2 01/23/22, 10:07
this is a v12 side effect of making translate VH strict_types=1 in #96473 -
Christian Kuhn updated the commit message in patch set 3 01/23/22, 10:08
-
Christian Kuhn voted on patch set 3 V +1 CR +1 01/23/22, 10:09
-
Georg Ringer commented on patch set 3 01/23/22, 10:10
TableKeyValue.html:35we could skip the spaceless by just using {f:if(condition:val,then:'true',else:'false')} -
Christian Kuhn voted on patch set 3 V 0 CR 0 01/23/22, 10:12
-
core-ci voted on patch set 3 V +1 01/23/22, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22428
-
Susi Moog commented on patch set 3 01/23/22, 11:43
Reply
yes, but it's good that it's now stricter, so we actually see what is missing ;)TableKeyValue.html:35ReplyI find it a lot more readable like this, as string true/false in a condition tend to be confusing, but I'm fine with both ways. -
Oliver Klee voted on patch set 3 CR +1 01/23/22, 11:44
-
Christian Kuhn commented on patch set 3 V +1 CR +1 01/23/22, 11:52
TableKeyValue.html:35Reply Unresolvedi can live with both and will vote the patch +1 as is. -
Oliver Hader voted on patch set 3 CR +1 01/24/22, 07:41
-
Stefan Bürk voted on patch set 3 V +1 CR +1 01/24/22, 19:00
-
Christian Kuhn voted on patch set 3 V +2 CR +2 01/25/22, 06:14
-
Christian Kuhn merged patch set 4 01/25/22, 06:14