Review main Merged

73132[TASK] Don't match generic render() in extension scanner

Christian Kuhn CR +2 V +2 Easy +1 −7 updated 01/24/22, 14:45

Commit message

Matching method name render() with more than zero
arguments is so generic that it gives tons of false
positives in the extension scanner. We shouldn't
scan for this.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 01/23/22, 10:35

  2. core-ci voted on patch set 1 V +1 01/23/22, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22429

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 01/24/22, 13:55

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 01/24/22, 14:44

  5. Oli Bartsch merged patch set 2 01/24/22, 14:45