Review 11.5 Merged

73133[BUGFIX] Resolve DOM elements in NavigationContainer on usage

Oliver Hader CR +2 V +2 Normal +36 −21 updated 01/25/22, 12:55

Commit message

There have been reports that DOM elements that were assigned in the
constructor of NavigationContainer actually were not available/ready
in the corresponding DOM.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Oliver Hader uploaded patch set 1 01/24/22, 08:12

  2. core-ci voted on patch set 1 V +1 01/24/22, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22441

  3. Benjamin Franzke voted on patch set 1 V +1 CR +1 01/24/22, 12:23

  4. Benjamin Franzke commented on patch set 1 V +2 CR +2 01/25/22, 12:55

    Verified the fix using a "Slow 3G" network throttling and aggressively cached javascript ressources. => Causes JS to be executed earlier than the DOM is loaded. This fix resolves the issue.
  5. Benjamin Franzke merged patch set 2 01/25/22, 12:55