Review main Merged

73139[BUGFIX] Use regular variable access in import/export backend module

Oliver Hader CR +2 V +2 Easy +1 −1 updated 01/24/22, 17:24

Commit message

It seems a nested variable access in Fluid `{{var}}` instead of
`{var}` has been used - which leads to a fatal error in PHP 8.1
due to Fluid's data retrieval process.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Oliver Hader uploaded patch set 1 01/24/22, 16:32

  2. core-ci voted on patch set 1 V +1 01/24/22, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22473

  3. Benjamin Franzke voted on patch set 1 V +1 CR +1 01/24/22, 16:44

  4. Christian Kuhn updated the commit message in patch set 2 01/24/22, 16:52

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 01/24/22, 16:52

  6. Christian Kuhn commented on patch set 2 01/24/22, 16:55

    that was me in https://review.typo3.org/c/Packages/TYPO3.CMS/+/73033 ... sorry for this one and thanks for the quick fix!
  7. Benjamin Franzke voted on patch set 2 V +1 CR +1 01/24/22, 16:57

  8. core-ci voted on patch set 2 V +1 01/24/22, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22476

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 01/24/22, 17:04

  10. Christian Kuhn merged patch set 3 01/24/22, 17:04

  11. Oliver Hader commented on patch set 3 01/24/22, 17:24

    Reply

    Never mind... :)