7314[BUGFIX] Fix path check for custom RTE styles
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Stefan Neufeind +1
- Julian Hofmann +1
- Stanislas Rolland +1
-
Verified V +2
- Steffen Ritter +2
- Stefan Neufeind +1
- Julian Hofmann +1
- Stanislas Rolland +1
Issues 1
Files 1
Review log 24
-
Stanislas Rolland commented on patch set 1 12/17/11, 15:43
I would prefer that you didn't submit this See inline comment.class.tx_rtehtmlarea_base.php:453I think the error is on this line: $filename = should be $fileName = -
Stanislas Rolland commented on patch set 2 12/17/11, 15:43
(1 inline comment) -
Stanislas Rolland uploaded patch set 2 12/17/11, 15:43
-
Stefan Neufeind commented on patch set 1 12/17/11, 15:43
Affects the releases 4.5.9 and 4.6.2 as of today (as well as master). How to test: * Create a fileadmin/rte.css * Add page-TS: RTE.default.contentCSS = fileadmin/rte.css * Try editing content in RTE -> falls back to default.css -
Stefan Neufeind commented on patch set 1 12/17/11, 15:43
@Stanislas: It still won't work as the path is incorrect afterwards. Please see the forge-entry for some details and try it yourself. -
Markus Klein commented on patch set 2 12/17/11, 15:43
(1 inline comment)class.tx_rtehtmlarea_base.php:456Why not merging the two ifs? -
Stanislas Rolland uploaded patch set 4 12/17/11, 15:43
-
Markus Klein commented on patch set 3 12/17/11, 15:43
Ok, will revert then. -
Markus Klein uploaded patch set 3 12/17/11, 15:43
-
Stanislas Rolland commented on patch set 5 12/17/11, 15:43
Verified; Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 5 12/17/11, 15:43
Verified; Looks good to me, but someone else must approve Stanislas: Thank you! Tested this with relative path as well as an EXT:...-path (both sysext and local ext). Works for me. -
Stefan Neufeind commented on patch set 5 12/17/11, 15:43
(1 inline comment) -
Markus Klein commented on patch set 5 12/17/11, 15:43
Sorry, that was to the exact same time... Feel free to repush your version in case mine is not ok. -
Markus Klein uploaded patch set 5 12/17/11, 15:43
-
Julian Hofmann commented on patch set 5 12/17/11, 15:43
Verified; Looks good to me, but someone else must approve Looks good. Works. Tested with 4.5.9, IE7 -
Steffen Ritter commented on patch set 2 12/17/11, 15:43
Verified; Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 2 12/17/11, 15:43
thanks Stan this would have been the way I would had changed the Patch, too -
Steffen Ritter commented on patch set 5 V 0 12/17/11, 15:43
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 12/17/11, 15:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2763/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/17/11, 15:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2765/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/17/11, 15:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2768/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/17/11, 15:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2769/ : SUCCESS -
Mr. Jenkins commented on patch set 5 12/17/11, 15:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2770/ : SUCCESS -
Stanislas Rolland merged patch set 5 12/17/11, 15:43