Review main Merged

73144[TASK] Extend .phpstorm.meta.php for further autocompletion support

Stefan Bürk CR +2 V +2 Normal +51 −0 updated 01/25/22, 09:41

Commit message

Extend PHPStorm meta file with further definitions for autocompletion
support and avoid unnecessary php docblocks in the code base.

* add request getAttribute() return types
* add return type for 'SiteMatcher->matchRequest()'
* add return type for 'PageRouter->matchRequest()'

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. Stefan Bürk uploaded patch set 1 01/24/22, 21:02

  2. Stefan Bürk uploaded patch set 2 01/24/22, 21:02

  3. core-ci voted on patch set 1 V +1 01/24/22, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22489

  4. core-ci voted on patch set 2 V +1 01/24/22, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22490

  5. Christian Kuhn commented on patch set 2 01/25/22, 07:55

    .phpstorm.meta.php:110

    this sentence is somehow broken.
  6. Stefan Bürk uploaded patch set 3 01/25/22, 08:35

  7. Stefan Bürk commented on patch set 3 01/25/22, 08:35

    .phpstorm.meta.php:110 Reply

    Done
  8. core-ci voted on patch set 3 V +1 01/25/22, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22502

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 01/25/22, 08:59

  10. Benni Mack voted on patch set 3 V +2 CR +2 01/25/22, 09:41

  11. Benni Mack merged patch set 4 01/25/22, 09:41