73145[TASK] Tag importmaps to include configuration for dynamic imports
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 10
- typo3/sysext/backend/Classes/ContextMenu/ImportMapConfigurator.phpnew+30 −0
- typo3/sysext/backend/Classes/Controller/BackendController.php+2 −0
- typo3/sysext/backend/Configuration/JavaScriptModules.php+4 −0
- typo3/sysext/backend/Configuration/Services.yaml+4 −0
- typo3/sysext/core/Classes/Page/Event/ResolveJavaScriptImportEvent.phpnew+38 −0
- typo3/sysext/core/Classes/Page/ImportMap.php4+42 −16
- typo3/sysext/core/Classes/Page/ImportMapFactory.php+7 −11
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+5 −0
- typo3/sysext/form/Configuration/JavaScriptModules.php+3 −0
- typo3/sysext/impexp/Configuration/JavaScriptModules.php+3 −0
Review log 1828
Show 13 earlier messages
-
Benjamin Franzke uploaded patch set 1 01/25/22, 05:19
-
core-ci voted on patch set 1 V -1 01/25/22, 05:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22497
-
core-ci commented on patch set 1 01/25/22, 08:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22497
-
Benjamin Franzke uploaded patch set 2 01/25/22, 08:37
-
core-ci voted on patch set 2 V +1 01/25/22, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22503
-
Benjamin Franzke uploaded patch set 3 01/31/22, 13:38
-
core-ci voted on patch set 3 V +1 01/31/22, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22802
-
Benjamin Franzke uploaded patch set 4 01/31/22, 13:56
-
Benjamin Franzke uploaded patch set 5 01/31/22, 14:06
-
core-ci voted on patch set 4 V +1 01/31/22, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22807
-
core-ci voted on patch set 5 V +1 01/31/22, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22811
-
Benjamin Franzke rebased onto patch set 6 02/01/22, 13:55
-
core-ci voted on patch set 6 V +1 02/01/22, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22877
-
Benni Mack updated the commit message in patch set 7 02/07/22, 16:00
-
core-ci voted on patch set 7 V +1 02/07/22, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23150
-
Benjamin Franzke uploaded patch set 8 02/08/22, 06:03
-
core-ci voted on patch set 8 V +1 02/08/22, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23185
-
Benni Mack voted on patch set 8 V +1 CR +1 02/08/22, 06:24
-
Christian Kuhn commented on patch set 8 02/10/22, 06:16
-
Benjamin Franzke commented on patch set 8 02/10/22, 12:40
ImportMap.php:45ReplyThe importmap is used in installtool without caches and without eventdispatcher (not needed): https://github.com/TYPO3/typo3/blob/main/typo3/sysext/install/Classes/Controller/LayoutController.php#L77 Therefore nullable is allowed here. In regular DI context it is actually always resolved due to the ImportMapFactory. -
Christian Kuhn commented on patch set 8 02/10/22, 14:41
ImportMap.php:45ReplyAck. Thx! maybe add a comment on this? that situation with the install tool was not obvious to me. -
Benjamin Franzke uploaded patch set 9 02/11/22, 14:33
-
Benjamin Franzke commented on patch set 9 02/11/22, 14:33
ImportMap.php:45ReplyDone. -
core-ci voted on patch set 9 V +1 02/11/22, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23399
-
Christian Kuhn voted on patch set 9 V +1 CR +1 02/11/22, 15:41
-
Benni Mack voted on patch set 9 V +1 CR +1 02/12/22, 17:11
-
Benjamin Franzke voted on patch set 9 V +2 CR +2 02/13/22, 10:47
-
Benjamin Franzke merged patch set 10 02/13/22, 10:47
ImportMap.php:45