73146[TASK] Avoid misusing ModuleTemplate in element browser
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+16 −29
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php3+9 −6
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php2+8 −6
- typo3/sysext/recordlist/Classes/Browser/FolderBrowser.php2+8 −6
- typo3/sysext/recordlist/Classes/Browser/RecordBrowser.php+3 −0
- typo3/sysext/recordlist/Resources/Private/Layouts/ElementBrowser.htmlrenamed+7 −0
- typo3/sysext/recordlist/Resources/Private/Layouts/ElementBrowserWithNavigation.htmlrenamed+7 −0
- typo3/sysext/recordlist/Resources/Private/Templates/ElementBrowser.htmlrenamed+8 −1
Review log 78
-
Christian Kuhn uploaded patch set 1 01/25/22, 08:50
-
core-ci voted on patch set 1 V +1 01/25/22, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22505
-
Benni Mack voted on patch set 1 V +1 CR +1 01/25/22, 09:44
-
Stefan Bürk commented on patch set 1 01/25/22, 09:54
FileBrowser.php:207Same, closing bodytag not needed ?FolderBrowser.php:112closing body tag ? -
Christian Kuhn commented on patch set 1 01/25/22, 10:00
DatabaseBrowser.php:122Replyno. that's one of the pageRenderer shenanigans: it has </body> automatically, but not <body>FileBrowser.php:207ReplyDoneFolderBrowser.php:112ReplyDone -
Stefan Bürk commented on patch set 1 V +1 CR +1 01/25/22, 10:07
DatabaseBrowser.php:122ReplyThanks for that info. Found it in the template. -
Christian Kuhn voted on patch set 1 V +2 CR +2 01/25/22, 11:02
-
Christian Kuhn merged patch set 2 01/25/22, 11:02
DatabaseBrowser.php:122