Review main Merged

73146[TASK] Avoid misusing ModuleTemplate in element browser

Christian Kuhn CR +2 V +2 Normal +66 −48 updated 01/25/22, 11:02

Commit message

The element browser - selecting records for type="group"
and "Add image" in FAL - are modals without doc header
and should not use ModuleTemplate but use PageRenderer
directly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 78

  1. Christian Kuhn uploaded patch set 1 01/25/22, 08:50

  2. core-ci voted on patch set 1 V +1 01/25/22, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22505

  3. Benni Mack voted on patch set 1 V +1 CR +1 01/25/22, 09:44

  4. Stefan Bürk commented on patch set 1 01/25/22, 09:54

    DatabaseBrowser.php:122

    Closing bodytag "</body>" not needed after content ? Is this not invalid html ?

    FileBrowser.php:207

    Same, closing bodytag not needed ?

    FolderBrowser.php:112

    closing body tag ?
  5. Christian Kuhn commented on patch set 1 01/25/22, 10:00

    DatabaseBrowser.php:122 Reply

    no. that's one of the pageRenderer shenanigans: it has </body> automatically, but not <body>

    FileBrowser.php:207 Reply

    Done

    FolderBrowser.php:112 Reply

    Done
  6. Stefan Bürk commented on patch set 1 V +1 CR +1 01/25/22, 10:07

    DatabaseBrowser.php:122 Reply

    Thanks for that info. Found it in the template.
  7. Christian Kuhn voted on patch set 1 V +2 CR +2 01/25/22, 11:02

  8. Christian Kuhn merged patch set 2 01/25/22, 11:02