Review main Merged

73147[BUGFIX] Remove element browser registration for 'file_reference'

Christian Kuhn CR +2 V +2 Easy +0 −1 updated 01/25/22, 09:59

Commit message

The element browser 'file_reference' can't be reached
anymore since the removal of type="group"
internal_type="file_reference" in v10.

The registration is dropped.

For the other three types:
'db' is the type="group" internal_type="db" modal
'folder' is the type="group" internal_type="folder" modal
'file' is the FAL "Add image" modal

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 01/25/22, 09:18

  2. core-ci voted on patch set 1 V +1 01/25/22, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22506

  3. Benni Mack voted on patch set 1 V +1 CR +1 01/25/22, 09:33

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 01/25/22, 09:55

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 01/25/22, 09:59

  6. Christian Kuhn merged patch set 2 01/25/22, 09:59