Review main Merged

73151[TASK] Avoid misusing ModuleTemplate in link handler

Christian Kuhn CR +2 V +2 Normal +33 −71 updated 01/25/22, 14:39

Commit message

The link handler, used when e.g. selecting things in
tt_content header_link and when editing links in RTE,
are modals without doc header and should not use
ModuleTemplate but use PageRenderer directly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 56

  1. Christian Kuhn uploaded patch set 1 01/25/22, 14:14

  2. core-ci voted on patch set 1 V +1 01/25/22, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22520

  3. Benni Mack voted on patch set 1 V +1 CR +1 01/25/22, 14:37

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 01/25/22, 14:38

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 01/25/22, 14:39

  6. Christian Kuhn merged patch set 2 01/25/22, 14:39