Review 11.5 Merged

73163[TASK] Avoid reading languagefiles if argument is empty

Benjamin Franzke CR +2 V +2 Easy +4 −0 updated 01/28/22, 14:26

Commit message

'LanguageService->sL()' could be called with an empty
input string, thus reading language files and caching
the result is superflous.

This patch adds an early check and return to 'sL()'
to mitigate that.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Benjamin Franzke commented on patch set 1 01/28/22, 13:10

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/28/22, 13:10

  3. core-ci voted on patch set 1 V +1 01/28/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22623

  4. Oliver Klee voted on patch set 1 CR +1 01/28/22, 13:24

  5. Benjamin Franzke merged patch set 2 01/28/22, 14:26