Review main Merged

73173[BUGFIX] Avoid not closing form in SetupModuleController

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 01/25/22, 16:22

Commit message

The form tag in 'User Settings' is never closed
since that tag is added too late to $this->content.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Jochen Roth +1
    • Stefan Bürk +1

Issues 1

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 01/25/22, 16:05

  2. Christian Kuhn updated the commit message in patch set 2 01/25/22, 16:06

  3. Jochen Roth voted on patch set 2 V +1 CR +1 01/25/22, 16:07

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 01/25/22, 16:11

  5. Benni Mack voted on patch set 2 V +2 CR +2 01/25/22, 16:12

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 01/25/22, 16:13

  7. Christian Kuhn merged patch set 3 01/25/22, 16:13

  8. core-ci voted on patch set 1 V +1 01/25/22, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22533

  9. core-ci voted on patch set 2 V +1 01/25/22, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22534