73175[BUGFIX] Fix undefined key warning in cObj->imageLinkWrap
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Robert Kärner +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 4
Review log 2132
Show 47 earlier messages
-
Robert Kärner uploaded patch set 1 01/26/22, 09:10
-
core-ci voted on patch set 1 V -1 01/26/22, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22554
-
Robert Kärner uploaded patch set 2 01/26/22, 09:19
-
Robert Kärner uploaded patch set 3 01/26/22, 09:21
-
Robert Kärner commented on patch set 3 01/26/22, 09:23
-
core-ci voted on patch set 2 V +1 01/26/22, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22555
-
core-ci voted on patch set 3 V +1 01/26/22, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22556
-
Nikita Hovratov uploaded patch set 4 01/28/22, 22:04
-
core-ci voted on patch set 4 V -1 01/28/22, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22638
-
Nikita Hovratov commented on patch set 4 V +1 CR +1 01/28/22, 22:08
Hey, I added tests for ContentObjectRenderer->imageLinkWrap to verify the patch. Also found another warning by that :) -
Nikita Hovratov uploaded patch set 5 01/28/22, 22:09
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 01/28/22, 22:12
-
core-ci voted on patch set 5 V +1 01/28/22, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22639
-
Nikita Hovratov uploaded patch set 6 01/29/22, 11:17
-
core-ci voted on patch set 6 V +1 01/29/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22653
-
Christian Kuhn uploaded patch set 7 02/05/22, 09:16
-
Christian Kuhn commented on patch set 7 02/05/22, 09:16
rebased. phpstan now found 2 violations in the test ;) -
core-ci voted on patch set 7 V +1 02/05/22, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23045
-
Oliver Klee commented on patch set 7 CR -1 02/05/22, 11:51
-1 so we don't forget to resolve the PHPStan warnings first. -
Nikita Hovratov uploaded patch set 8 02/05/22, 15:07
-
Oliver Klee voted on patch set 8 CR +1 02/05/22, 15:14
-
core-ci voted on patch set 8 V -1 02/05/22, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23074
-
core-ci commented on patch set 8 02/05/22, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23074
-
core-ci commented on patch set 8 02/05/22, 19:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23074
-
Nikita Hovratov uploaded patch set 9 02/05/22, 21:20
-
core-ci voted on patch set 9 V +1 02/05/22, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23075
-
Christian Kuhn voted on patch set 9 V +1 CR +1 02/05/22, 22:14
-
Oliver Klee voted on patch set 9 CR +1 02/05/22, 23:31
-
Stefan Bürk voted on patch set 9 V +1 CR +1 02/06/22, 13:56
-
Robert Kärner voted on patch set 9 CR +1 02/07/22, 06:50
-
Christian Kuhn voted on patch set 9 V +2 CR +2 02/07/22, 08:44
-
Christian Kuhn merged patch set 10 02/07/22, 08:44
ContentObjectRenderer.php:1081