Review main Merged

73177[TASK] Remove @internal from configuration exceptions

Stephan Großberndt CR +2 V +2 Easy +3 −7 updated 01/27/22, 19:36

Commit message

This change removes the `@internal` declaration from two exceptions
thrown by `ExtensionConfiguration->get()` which is used by extension
authors when fetching the extension configuration as those may be
caught by extension code.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Robert Kärner +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Robert Kärner +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Stephan Großberndt uploaded patch set 1 01/27/22, 13:16

  2. core-ci voted on patch set 1 V +1 01/27/22, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22565

  3. Robert Kärner voted on patch set 1 V +1 CR +1 01/27/22, 14:25

  4. Oliver Klee voted on patch set 1 CR +1 01/27/22, 16:11

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/27/22, 19:36

  6. Benjamin Franzke merged patch set 2 01/27/22, 19:36